fix bug: the metrics of caches is lost

Change-Id: If99b20ea1d37cbaca8f844d7796b11bb9cfbd601
apache · Jan 7, 2019 · 55816db · 55816db
1 parent 7164a45
commit 55816db
Showing 1 changed file with 9 additions and 11 deletions.
diff --git a/hugegraph-api/src/main/java/com/baidu/hugegraph/core/GraphManager.java b/hugegraph-api/src/main/java/com/baidu/hugegraph/core/GraphManager.java
@@ -54,7 +54,6 @@
 import com.baidu.hugegraph.task.TaskManager;
 import com.baidu.hugegraph.util.E;
 import com.baidu.hugegraph.util.Log;
-import com.codahale.metrics.MetricRegistry;
 
 public final class GraphManager {
 
@@ -226,15 +225,16 @@ private void addMetrics(HugeConfig config) {
             return maxWriteThreads;
         });
 
-        // Add metrics for cache
+        // Add metrics for caches
         Map<String, Cache> caches = CacheManager.instance().caches();
-        final AtomicInteger lastCaches = new AtomicInteger(caches.size());
+        registerCacheMetrics(caches);
+        final AtomicInteger lastCachesSize = new AtomicInteger(caches.size());
         MetricsUtil.registerGauge(Cache.class, "instances", () -> {
             int count = caches.size();
-            if (count != lastCaches.get()) {
-                registerCacheMetrics();
-            } else {
-                lastCaches.set(count);
+            if (count != lastCachesSize.get()) {
+                // Update if caches changed (effect in the next report period)
+                registerCacheMetrics(caches);
+                lastCachesSize.set(count);
             }
             return count;
         });
@@ -248,10 +248,8 @@ private void addMetrics(HugeConfig config) {
         });
     }
 
-    private void registerCacheMetrics() {
-        Map<String, Cache> caches = CacheManager.instance().caches();
-        final MetricRegistry registry = MetricManager.INSTANCE.getRegistry();
-        Set<String> names = registry.getNames();
+    private static void registerCacheMetrics(Map<String, Cache> caches) {
+        Set<String> names = MetricManager.INSTANCE.getRegistry().getNames();
         for (Map.Entry<String, Cache> entry : caches.entrySet()) {
             String key = entry.getKey();
             Cache cache = entry.getValue();