call updateIfAbsent() for schema insert

Change-Id: I02989962791fa369600f8dedbfd56e2b40c79077
apache · Jun 6, 2022 · 40a5196 · 40a5196
1 parent 73c7fb8
commit 40a5196
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/BackendTable.java b/hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/BackendTable.java
@@ -69,7 +69,7 @@ protected void registerMetaHandlers() {
     public void updateIfPresent(Session session, Entry entry) {
         // TODO: use fine-grained row lock
         synchronized (this.table) {
-            assert !session.hasChanges();
+            assert session == null || !session.hasChanges();
             if (this.queryExist(session, entry)) {
                 this.insert(session, entry);
                 if (session != null) {
@@ -82,7 +82,7 @@ public void updateIfPresent(Session session, Entry entry) {
     public void updateIfAbsent(Session session, Entry entry) {
         // TODO: use fine-grained row lock
         synchronized (this.table) {
-            assert !session.hasChanges();
+            assert session == null || !session.hasChanges();
             if (!this.queryExist(session, entry)) {
                 this.insert(session, entry);
                 if (session != null) {

diff --git a/hugegraph-core/src/main/java/com/baidu/hugegraph/backend/tx/SchemaTransaction.java b/hugegraph-core/src/main/java/com/baidu/hugegraph/backend/tx/SchemaTransaction.java
@@ -408,11 +408,11 @@ private void saveSchema(SchemaElement schema, boolean update) {
 
             if (update) {
                 this.doUpdateIfPresent(entry);
-                // TODO: support updateIfPresent
+                // TODO: also support updateIfPresent for index-update
                 this.indexTx.updateNameIndex(schema, false);
             } else {
-                // TODO: support updateIfAbsentProperty
-                this.doInsert(entry);
+                // TODO: support updateIfAbsentProperty (property: label name)
+                this.doUpdateIfAbsent(entry);
                 this.indexTx.updateNameIndex(schema, false);
             }