Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(loader): support file name with prefix for hdfs source #571

Merged
merged 8 commits into from
Mar 19, 2024

Conversation

JackyYangPassion
Copy link
Contributor

@JackyYangPassion JackyYangPassion commented Jan 23, 2024

Purpose of the PR

Main Changes

support file name with prefix for hdfs source

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working enhancement New feature or request java Pull requests that update Java code loader hugegraph-loader labels Jan 23, 2024
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 62.10%. Comparing base (b066b80) to head (98f2602).
Report is 26 commits behind head on master.

Files Patch % Lines
...e/hugegraph/loader/reader/hdfs/HDFSFileReader.java 80.00% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #571      +/-   ##
============================================
- Coverage     62.49%   62.10%   -0.39%     
+ Complexity     1903      932     -971     
============================================
  Files           262       93     -169     
  Lines          9541     4550    -4991     
  Branches        886      532     -354     
============================================
- Hits           5963     2826    -3137     
+ Misses         3190     1513    -1677     
+ Partials        388      211     -177     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imbajin imbajin requested review from zyxxoo and simon824 February 1, 2024 11:20
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Mar 19, 2024
Copy link
Member

@simon824 simon824 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 19, 2024
Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get it, keep the logic simple now

@imbajin imbajin merged commit 39f670a into apache:master Mar 19, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request java Pull requests that update Java code lgtm This PR has been approved by a maintainer loader hugegraph-loader size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Improve] Loader support file name with prefix for hdfs source
3 participants