Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refact(client): update tests for new OLTP traverser APIs #550

Merged
merged 14 commits into from
Dec 12, 2023
Merged

refact(client): update tests for new OLTP traverser APIs #550

merged 14 commits into from
Dec 12, 2023

Conversation

DanGuge
Copy link
Contributor

@DanGuge DanGuge commented Dec 9, 2023

Purpose of the PR

Main Changes

Updata api tests with new traverser structure

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@github-actions github-actions bot added the client hugegraph-client label Dec 9, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 9, 2023 •
edited
Loading

Codecov Report

Attention: 66 lines in your changes are missing coverage. Please review.

Comparison is base (b066b80) 62.49% compared to head (6b3e45e) 62.50%.
Report is 7 commits behind head on master.

Files Patch % Lines
.../apache/hugegraph/structure/traverser/VESteps.java 53.48% 20 Missing ⚠️
...ugegraph/structure/traverser/KneighborRequest.java 66.66% 4 Missing ⚠️
...che/hugegraph/structure/traverser/KoutRequest.java 69.23% 4 Missing ⚠️
...ache/hugegraph/structure/traverser/ApiMeasure.java 25.00% 3 Missing ⚠️
...g/apache/hugegraph/structure/traverser/VEStep.java 80.00% 3 Missing ⚠️
...n/java/org/apache/hugegraph/driver/HugeClient.java 33.33% 2 Missing ⚠️
...egraph/structure/traverser/CrosspointsRequest.java 60.00% 2 Missing ⚠️
...aph/structure/traverser/CustomizedCrosspoints.java 0.00% 2 Missing ⚠️
...gegraph/structure/traverser/JaccardSimilarity.java 66.66% 2 Missing ⚠️
...pache/hugegraph/structure/traverser/Kneighbor.java 0.00% 2 Missing ⚠️
... and 16 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             master     #550    +/-   ##
==========================================
  Coverage     62.49%   62.50%            
- Complexity     1903     1919    +16     
==========================================
  Files           262      266     +4     
  Lines          9541     9658   +117     
  Branches        886      887     +1     
==========================================
+ Hits           5963     6037    +74     
- Misses         3190     3232    +42     
- Partials        388      389     +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added hubble hugegraph-hubble loader hugegraph-loader tools hugegraph-tools labels Dec 9, 2023
@imbajin imbajin added this to the 1.2.0 milestone Dec 9, 2023
@simon824 simon824 mentioned this pull request Dec 9, 2023
Closed
11 tasks
simon824
simon824 reviewed Dec 9, 2023
View reviewed changes
.github/workflows/client-ci.yml Outdated Show resolved Hide resolved
.github/workflows/hubble-ci.yml Outdated Show resolved Hide resolved
.github/workflows/loader-ci.yml Outdated Show resolved Hide resolved
.github/workflows/tools-ci.yml Outdated Show resolved Hide resolved
@simon824
Copy link
Member

simon824 commented Dec 9, 2023

ci error

2023-12-09T14:30:28.1358860Z 	at org.apache.hugegraph.functional.MetricsManagerTest.testAllMetrics(MetricsManagerTest.java:49)
2023-12-09T14:30:28.1359093Z Caused by: com.fasterxml.jackson.core.JsonParseException: 
2023-12-09T14:30:28.1359682Z Unexpected character ('#' (code 35)): expected a valid value (JSON String, Number, Array, Object or token 'null', 'true' or 'false')
2023-12-09T14:30:28.1359848Z  at [Source: (StringReader); line: 1, column: 2]
2023-12-09T14:30:28.1360258Z 	at org.apache.hugegraph.functional.MetricsManagerTest.testAllMetrics(MetricsManagerTest.java:49)

@DanGuge
Copy link
Contributor Author

DanGuge commented Dec 9, 2023 •
edited by imbajin
Loading

ci error

2023-12-09T14:30:28.1358860Z 	at org.apache.hugegraph.functional.MetricsManagerTest.testAllMetrics(MetricsManagerTest.java:49)
2023-12-09T14:30:28.1359093Z Caused by: com.fasterxml.jackson.core.JsonParseException: 
2023-12-09T14:30:28.1359682Z Unexpected character ('#' (code 35)): expected a valid value (JSON String, Number, Array, Object or token 'null', 'true' or 'false')
2023-12-09T14:30:28.1359848Z  at [Source: (StringReader); line: 1, column: 2]
2023-12-09T14:30:28.1360258Z 	at org.apache.hugegraph.functional.MetricsManagerTest.testAllMetrics(MetricsManagerTest.java:49)

due to changes in MetricsAPI.java

cc @imbajin -> cc @SunnyBoy-WYH

javeme
javeme reviewed Dec 9, 2023
View reviewed changes
hugegraph-client/src/main/java/org/apache/hugegraph/structure/traverser/VEStepEntity.java Outdated Show resolved Hide resolved
hugegraph-client/src/main/java/org/apache/hugegraph/structure/traverser/VESteps.java Show resolved Hide resolved
hugegraph-client/src/main/java/org/apache/hugegraph/structure/traverser/VESteps.java Outdated Show resolved Hide resolved
hugegraph-client/src/main/java/org/apache/hugegraph/structure/traverser/WeightedPath.java Outdated Show resolved Hide resolved
hugegraph-client/src/test/java/org/apache/hugegraph/api/traverser/KneighborApiTest.java Outdated Show resolved Hide resolved
hugegraph-client/src/main/java/org/apache/hugegraph/structure/traverser/VEStepEntity.java Outdated Show resolved Hide resolved
hugegraph-client/src/test/java/org/apache/hugegraph/api/auth/TokenApiTest.java Outdated Show resolved Hide resolved
hugegraph-client/src/test/java/org/apache/hugegraph/api/traverser/CountApiTest.java Show resolved Hide resolved
hugegraph-client/src/test/java/org/apache/hugegraph/api/traverser/KneighborApiTest.java
builder.step().direction(Direction.BOTH)
.properties("date", "P.gt(\"2014-01-01 00:00:00\")");
builder.steps()
.direction(Direction.BOTH)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can move direction into VEStepEntity in the future

hugegraph-client/src/test/java/org/apache/hugegraph/api/traverser/KneighborApiTest.java Outdated Show resolved Hide resolved
@DanGuge DanGuge requested review from javeme and simon824 December 10, 2023 01:53
@imbajin imbajin changed the title fix(client): Update tests with new traverser apis refact(client): update tests for new OLTP traverser APIs Dec 11, 2023
@imbajin imbajin mentioned this pull request Dec 11, 2023
Merged
11 tasks
imbajin
imbajin reviewed Dec 12, 2023
View reviewed changes
hugegraph-client/src/test/java/org/apache/hugegraph/api/traverser/CountApiTest.java
@@ -253,6 +254,7 @@ public void testCountWithLabel() {
}

@Test
@Ignore
public void testCountWithProperties() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note：This test ignore now & need handle it later

@simon824 simon824 merged commit 0e1caa0 into apache:master Dec 12, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon824 simon824 simon824 approved these changes

@imbajin imbajin imbajin approved these changes

@JackyYangPassion JackyYangPassion Awaiting requested review from JackyYangPassion

@javeme javeme Awaiting requested review from javeme

Assignees
No one assigned
Labels
client hugegraph-client hubble hugegraph-hubble loader hugegraph-loader tools hugegraph-tools
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@DanGuge @simon824 @javeme @imbajin @SunnyBoy-WYH