-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(client): increase the api num as the latest server commit + 10 #546
Conversation
Note: now the api version check range is: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add need update the depth param in install-from-server script for ci
@@ -109,7 +109,7 @@ private void initManagers(RestClient client, String graph) { | |||
|
|||
private void checkServerApiVersion() { | |||
VersionUtil.Version apiVersion = VersionUtil.Version.of(this.version.getApiVersion()); | |||
VersionUtil.check(apiVersion, "0.38", "0.70", "hugegraph-api in server"); | |||
VersionUtil.check(apiVersion, "0.38", "0.81", "hugegraph-api in server"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a comment for it (like why we need keep it as realNum + 10)
hugegraph-client/src/main/java/org/apache/hugegraph/driver/HugeClient.java
Show resolved
Hide resolved
# TODO: find a way to keep the range of api version correct automatically | ||
# 0.81 equals to the {latest_api_version} +10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line comments in java code should be //
rather than #
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I made a mistake. It was a simple error.
hugegraph-client/src/main/java/org/apache/hugegraph/driver/HugeClient.java
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #546 +/- ##
=========================================
Coverage 62.49% 62.49%
Complexity 1903 1903
=========================================
Files 262 262
Lines 9541 9541
Branches 886 886
=========================================
Hits 5963 5963
Misses 3190 3190
Partials 388 388 ☔ View full report in Codecov by Sentry. |
Purpose of the PR
Main Changes
Verifying these changes
tested by this yaml, where dandelionivy/hubble is my own repo
now we can connect to the graph:
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODO
Doc - Done
Doc - No Need