Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support edgeexistence api #539

Closed
wants to merge 4 commits into from

Conversation

msgui
Copy link
Contributor

@msgui msgui commented Nov 30, 2023

@msgui msgui closed this Nov 30, 2023
@github-actions github-actions bot added the client hugegraph-client label Nov 30, 2023
@msgui msgui deleted the support-edgeexist-test branch November 30, 2023 02:43
@msgui msgui restored the support-edgeexist-test branch November 30, 2023 02:43
@javeme javeme changed the title ---feat: support edgeexistence api feat: support edgeexistence api Nov 30, 2023
@javeme javeme reopened this Nov 30, 2023
public List<Edge> edgeExistence(Object sourceId, Object targetId, String edgeLabel,
String sortValues, long limit){
return this.edgeExistenceAPI.get(sourceId, targetId, edgeLabel,
sortValues, limit);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems one line is ok

Object lopId = getVertexId("software", "name", "lop");

edges = edgeExistenceAPI.get(lopId, vadasId,
"knows", "", 100);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems one line is ok

Object rippleId = getVertexId("person", "name", "ripple");

edges = edgeExistenceAPI.get(joshId, rippleId,
"created", "", 100);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems one line is ok

@@ -538,4 +541,10 @@ public Iterator<Edge> iteratorEdges(Shard shard, int sizePerPage) {
return this.edges(shard, page, sizePerPage);
});
}

public List<Edge> edgeExistence(Object sourceId, Object targetId, String edgeLabel,
String sortValues, long limit){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expect int limit

@@ -538,4 +541,10 @@ public Iterator<Edge> iteratorEdges(Shard shard, int sizePerPage) {
return this.edges(shard, page, sizePerPage);
});
}

public List<Edge> edgeExistence(Object sourceId, Object targetId, String edgeLabel,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also add this 2 versions:

edgeExistence(Object sourceId, Object targetId)
edgeExistence(Object sourceId, Object targetId, String edgeLabel)

@msgui msgui closed this Nov 30, 2023
@msgui msgui deleted the support-edgeexist-test branch November 30, 2023 09:21
@msgui msgui restored the support-edgeexist-test branch November 30, 2023 10:16
@msgui msgui reopened this Nov 30, 2023
@msgui msgui closed this Nov 30, 2023
@msgui
Copy link
Contributor Author

msgui commented Nov 30, 2023

Sorry, I'm currently using this branch for testing... PR in the wrong place. 😅 please ignore it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client hugegraph-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants