-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update common version and remove jersey code #538
Merged
Merged
Changes from 56 commits
Commits
Show all changes
60 commits
Select commit
Hold shift + click to select a range
884166c
Update client-ci.yml
zhenyuT cf729d5
replace jersey with okhttp
74f92dc
Merge remote-tracking branch 'origin/master'
3c10111
fix test error
1eabd9a
fix the problem that mockito can't mock final class
ab2f917
fix error
3fe0244
Update BaseClientTest.java
zhenyuT cb79e56
https support && add licence header
552a108
fix licence check error
9d211f8
fix error
a9c6c88
fix licence check error
bd5e5e7
fix error
277fe04
rename rest class && remove jersey dependency
1975bfd
add workflow_dispatch
ae9de53
add workflow_dispatch
41be461
Merge branch 'master' into release-removejersey
ecc5580
hubble error fix
5740701
update okhttp version of hubble
ef7846f
refactor class name
aff4455
add workflow_dispatch
d3d3daf
fix licence dependency check error
57a2144
Merge remote-tracking branch 'origin/master'
zhenyuT 389431a
feat: merge request
zhenyuT 93f83ab
chore(ci): add stage profile settings
zhenyuT a314397
Merge branch 'visit-stage'
zhenyuT 9c52320
update common version and fix code
zhenyuT 6bc34d6
fix
zhenyuT b855f62
Merge branch 'visit-stage'
zhenyuT c637fcd
fix
zhenyuT f45f176
update version
zhenyuT 150bb0e
fix spark-connector-ci
zhenyuT 75ff6d1
fix spark-connector-ci
zhenyuT 57e4d76
fix spark-connector-ci
zhenyuT fcd0735
update client version
zhenyuT 82b401a
update client version
zhenyuT 164a50a
Merge remote-tracking branch 'upstream/master'
zhenyuT ea06f2c
fix license-checker
zhenyuT 49a2343
code optimize
zhenyuT f0db02a
remove useless dependency
zhenyuT e593008
remove useless code
zhenyuT 3eb6c42
fix licence check
zhenyuT cda3e28
fix import & update api version
imbajin e03074c
remove redundant common import in hubble
imbajin 76a85ee
remove redundant lombok version
zhenyuT cdd1012
remove useless code
zhenyuT 30396fb
add comment
zhenyuT d9603c0
rename id
zhenyuT 0a09aac
add encode test case
zhenyuT 3f8b42d
add encode test case and fix code issue
zhenyuT 7e2f5ae
fix test error
zhenyuT bba55b8
fix test error
zhenyuT acc65e0
fix code issue
zhenyuT bb79524
fix code issue
zhenyuT 4441ac8
fix code issue
zhenyuT 0d215a4
update hg server commitId
zhenyuT e65644b
debug ci error
zhenyuT 142192a
revert commit ID & let it pass 100
imbajin a18802b
Update client-ci.yml
imbajin 4f1622c
Merge branch 'master' into master
imbajin a3b4423
tiny fix
imbajin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@imbajin can we share the same COMMIT_ID with client-ci.yml (just use an global env var)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do want it too but not found the way to achieve it, however I get a better way to avoid hard code commit ID in ci
we could use "latestCommitID - X" (X >= 15 maybe) to get the stable code in server & no need update the ID by ourselves if not necessary (will submit a PR after this adaptor) #542
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a method to use
latestCommitID - X
, but we can't control it freely. If we want to adapt to the latest code, we still need to change the X.we may try reusable-workflow: https://docs.github.com/en/actions/using-workflows/reusing-workflows#using-inputs-and-secrets-in-a-reusable-workflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Get it, but we can't set
secrets/variables
in settings, we lack the permission to set it 😢 (This is also the reason why in the early code, we could only write fixed commitID in multiple CI files)BTW, we could create/submit a
common action
and publish it to github action repo & let other actions to extend it if github supports