Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support docker for loader-1.0.0 #532

Merged
merged 4 commits into from
Nov 14, 2023

Conversation

aroundabout
Copy link
Contributor

Purpose of the PR

Main Changes

  1. add a dockerfile for loader-1.0.0
  2. tested as same as feat: support docker for loader #530
  3. demo image is https://hub.docker.com/repository/docker/dandelionivy/loader/general

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

❗ No coverage uploaded for pull request base (docker-1.0.0@55ad9c7). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             docker-1.0.0     #532   +/-   ##
===============================================
  Coverage                ?   62.55%           
  Complexity              ?     1866           
===============================================
  Files                   ?      260           
  Lines                   ?     9412           
  Branches                ?      872           
===============================================
  Hits                    ?     5888           
  Misses                  ?     3142           
  Partials                ?      382           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@imbajin imbajin merged commit 3f0a323 into apache:docker-1.0.0 Nov 14, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants