feat(hubble): support highlighting and hints in query statements #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
imbajin
changed the title
imbajin
changed the title
finished |
lionztt
reviewed
Nov 27, 2022
| @@ -197,6 +201,8 @@ export const GremlinQuery: React.FC = observer(() => { | |||
| { | |||
| lineNumbers: true, | |||
| lineWrapping: true, | |||
| mode: { name: 'text/x-mysql' }, | |||
There was a problem hiding this comment.
It looks like is mysql's hint config. I think that we should set config as gremlin's hint.
There was a problem hiding this comment.
seems right catch, thanks for ur reminder, would u also like to improve the FE module?
There was a problem hiding this comment.
yes, I'm learning the FE module codes
@lionztt any update for this PR? it should consider be merged and improve it later if no better solution now (due to the apache release next week)
|
Add gremlin keyword hints, basic function |
|
imbajin
approved these changes
Dec 13, 2022
simon824
approved these changes
Dec 15, 2022
Linary
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Query statements support highlighting and hints