feat: introduce hugegraph-dist module #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #279 +/- ##
=========================================
Coverage 75.74% 75.74%
Complexity 1847 1847
=========================================
Files 235 235
Lines 7766 7766
Branches 685 685
=========================================
Hits 5882 5882
Misses 1501 1501
Partials 383 383 Continue to review full report at Codecov.
|
imbajin
reviewed
May 13, 2022
hugegraph-dist/pom.xml
Outdated
Comment on lines
41
to
42
| <exec executable="${shell-executable}" | ||
| dir="${project.basedir}" failonerror="true"> |
hugegraph-dist/pom.xml
Outdated
Comment on lines
32
to
33
| <echo file="${project.basedir}/dist.sh"> | ||
| \cp -r ${project.parent.basedir}/hugegraph-hubble/hubble-dist/hugegraph-hubble-${project.version} ${project.basedir} |
There was a problem hiding this comment.
we could add a ls * to print files before cp
|
|
||
| <properties> | ||
| <release.name>${project.parent.artifactId}</release.name> | ||
| <final.name>${release.name}-${project.version}</final.name> |
There was a problem hiding this comment.
if remove these, release.name will be hugegraph-dist
| \cp -r ${project.parent.basedir}/hugegraph-tools/hugegraph-tools-${project.version} ${project.basedir} | ||
|
|
||
| tar -zcvf ${project.parent.basedir}/${final.name}.tar.gz \ | ||
| hugegraph-hubble-* hugegraph-loader-* hugegraph-tools-* || exit 1 |
There was a problem hiding this comment.
we could add a md5sum check after package it and attach it in release info
javeme
approved these changes
May 16, 2022
imbajin
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closed #278
