Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

单条插入任务超时时仍然有可能导致统计出错 #11

Closed
Linary opened this issue Oct 17, 2018 · 1 comment
Closed

单条插入任务超时时仍然有可能导致统计出错 #11

Linary opened this issue Oct 17, 2018 · 1 comment
Labels
bug Something isn't working

Comments

@Linary
Copy link
Contributor

Linary commented Oct 17, 2018 •
edited
Loading

  1. TaskManager里面对singleTasks超时的情况没有做处理，这样会导致主线程遗漏一部分顶点插入量，然后如果这些singleTasks在边插入的过程中完成了，那会被统计到边的结果里面。

    由于超时可能导致有部分记录没有插入，而且用户也不知道，故取消超时时间，将插入机制修改为必须等待插入完成，这样也能避免统计出错。

  2. TaskManager的shutdown部分忽略了singleExecutor。
@Linary Linary mentioned this issue Oct 17, 2018
Merged
Linary added a commit that referenced this issue Oct 23, 2018
@Linary
Fix two bug about single tasks and executor
5b59b0b 
1. When a single insert task times out, it may still cause statistical errors.
2. TaskManager.shutdown() ignored singleExecutor

Fix #11

Change-Id: I9a468241f369f4c7e73a95ba9a5772dac90e0ce1
@javeme javeme mentioned this issue Oct 23, 2018
Closed
Linary added a commit that referenced this issue Oct 26, 2018
@Linary
Fix two bug about single tasks and executor
84c5868 
1. When a single insert task times out, it may still cause statistical errors.
2. TaskManager.shutdown() ignored singleExecutor

Fix #11

Change-Id: I9a468241f369f4c7e73a95ba9a5772dac90e0ce1
Linary added a commit that referenced this issue Oct 30, 2018
@Linary
Fix two bug about single tasks and executor
a2ba0c9 
1. When a single insert task times out, it may still cause statistical errors.
2. TaskManager.shutdown() ignored singleExecutor

Fix #11

Change-Id: I9a468241f369f4c7e73a95ba9a5772dac90e0ce1
@Linary Linary mentioned this issue Nov 1, 2018
Closed
@Linary Linary added the bug Something isn't working label Nov 16, 2018
Linary added a commit that referenced this issue Nov 23, 2018
@Linary
Fix two bug about single tasks and executor
ed1d263 
1. When a single insert task times out, it may still cause statistical errors.
2. TaskManager.shutdown() ignored singleExecutor

Fix #11

Change-Id: I9a468241f369f4c7e73a95ba9a5772dac90e0ce1
Linary added a commit that referenced this issue Nov 23, 2018
@Linary
Fix two bug about single tasks and executor
8421f70 
1. When a single insert task times out, it may still cause statistical errors.
2. TaskManager.shutdown() ignored singleExecutor

Fix #11

Change-Id: I9a468241f369f4c7e73a95ba9a5772dac90e0ce1
javeme pushed a commit that referenced this issue Nov 23, 2018
@Linary @javeme
Fix two bug about single tasks and executor
a0b27a1 
1. When a single insert task times out, it may still cause statistical errors.
2. TaskManager.shutdown() ignored singleExecutor

Fix #11

Change-Id: I9a468241f369f4c7e73a95ba9a5772dac90e0ce1
@Linary
Copy link
Contributor Author

Linary commented Nov 23, 2018 •
edited
Loading

另一个会导致统计出错的问题：#3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Linary