refine rest-server.property documentation #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
imbajin
reviewed
Aug 2, 2024
Comment on lines
157
to
158
| # http://0.0.0.0:8080 to listen all network interfaces, but need to take care of security | ||
| # or listen to specific IP with port |
| @@ -170,7 +172,7 @@ server.id=server-1 | |||
| server.role=master | |||
| ``` | |||
|
|
|||
| - restserver.url：RestServer 提供服务的 url，根据实际环境修改； | |||
| - restserver.url：RestServer 提供服务的 url，根据实际环境修改。如果其他 IP 地址无法访问，可以尝试修改为特定的地址；或修改为 `http://0.0.0.0:8080` 来监听来自任何 IP 地址的请求，这种方案较为便捷，但安全性有所缺失； | |||
There was a problem hiding this comment.
无需携带端口, 或者 http/https, 只和 ip 有关
另外"安全性有所缺失" -> "需要留意服务可被访问的网络范围"
There was a problem hiding this comment.
sync with CN version (could also update in hubble's doc?)
There was a problem hiding this comment.
The default bind for hubble's config is 0.0.0.0, so I think user wouldn't meet this problem about accessing, mean while developers do not need to limit the accessibility of hubble.
So I think hubble does not need extra explanation.
imbajin
approved these changes
Aug 2, 2024
github-actions bot
pushed a commit
to zoroqi/incubator-hugegraph-doc
that referenced
this pull request
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
refine rest-server.property documentation
related to apache/incubator-hugegraph#2610