Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): support output filter #303

Merged
merged 20 commits into from
Aug 10, 2024
Merged

feat(core): support output filter #303

merged 20 commits into from
Aug 10, 2024

Conversation

diaohancai
Copy link
Contributor

Purpose of the PR

Main Changes

  1. computation results output supports custom write.
  2. SingleSourceShortestPathOutput implements org.apache.hugegraph.computer.core.output.ComputerOutput#filter

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows.
    org.apache.hugegraph.computer.algorithm.path.shortest.SingleSourceShortestPathTest

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

diaohancai and others added 17 commits November 21, 2023 15:38
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. feature New feature labels Jan 26, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 83.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 84.97%. Comparing base (e0b484a) to head (724fbd1).
Report is 11 commits behind head on master.

❗ Current head 724fbd1 differs from pull request most recent head c64b5c5

Please upload reports for the commit c64b5c5 to get more accurate results.

Files Patch % Lines
.../path/shortest/SingleSourceShortestPathOutput.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master     #303      +/-   ##
============================================
- Coverage     85.03%   84.97%   -0.06%     
- Complexity     3296     3366      +70     
============================================
  Files           349      360      +11     
  Lines         12485    12683     +198     
  Branches       1130     1151      +21     
============================================
+ Hits          10616    10778     +162     
- Misses         1329     1342      +13     
- Partials        540      563      +23

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coderzc
Copy link
Member

coderzc commented Feb 1, 2024

Please split algorithm module change to another PR.

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Mar 13, 2024
@diaohancai
Copy link
Contributor Author

Please split algorithm module change to another PR.

Done.

@imbajin imbajin requested a review from javeme March 13, 2024 08:16
javeme
javeme reviewed Mar 17, 2024
View reviewed changes
...ain/java/org/apache/hugegraph/computer/algorithm/path/shortest/SingleSourceShortestPath.java Outdated
@@ -278,4 +278,8 @@ private boolean isAllTargetsReached(Vertex vertex) {
}
return false;
}

public IdSet getTargetIdSet() {
return targetIdSet;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep this. prefix for members access

@diaohancai diaohancai requested a review from javeme June 2, 2024 02:42
@imbajin imbajin changed the title Feat(core): output filter feat(core): support output filter Jun 3, 2024
javeme
javeme approved these changes Aug 10, 2024
View reviewed changes
Copy link
Contributor

@javeme javeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 10, 2024
@imbajin imbajin merged commit e241d16 into apache:master Aug 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imbajin imbajin imbajin approved these changes

@javeme javeme javeme approved these changes

Assignees
No one assigned
Labels
feature New feature lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] output custom write
4 participants
@diaohancai @coderzc @javeme @imbajin