Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve(algorithm): random walk vertex inactive #301

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

diaohancai
Copy link
Contributor

Purpose of the PR

  • improve random walk algorithm

Main Changes

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows.

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. feature New feature labels Jan 1, 2024
Copy link

codecov bot commented Jan 1, 2024

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (e0b484a) 85.03% compared to head (a793509) 85.17%.
Report is 6 commits behind head on master.

❗ Current head a793509 differs from pull request most recent head c968235. Consider uploading reports for the commit c968235 to get more accurate results

Files Patch % Lines
...apache/hugegraph/computer/core/bsp/EtcdClient.java 52.38% 6 Missing and 4 partials ⚠️
.../hugegraph/computer/core/worker/WorkerService.java 85.93% 8 Missing and 1 partial ⚠️
.../hugegraph/computer/core/master/MasterService.java 50.00% 4 Missing and 3 partials ⚠️
...hugegraph/computer/core/util/StringEncodeUtil.java 54.54% 5 Missing ⚠️
...raph/computer/k8s/operator/OperatorEntrypoint.java 81.81% 2 Missing ⚠️
...h/computer/core/network/session/ClientSession.java 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #301      +/-   ##
============================================
+ Coverage     85.03%   85.17%   +0.14%     
- Complexity     3296     3300       +4     
============================================
  Files           349      349              
  Lines         12485    12461      -24     
  Branches       1130     1123       -7     
============================================
- Hits          10616    10614       -2     
+ Misses         1329     1307      -22     
  Partials        540      540              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

imbajin
imbajin previously approved these changes Jan 3, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 3, 2024
@imbajin imbajin requested review from javeme and coderzc January 3, 2024 11:34
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jan 5, 2024
@diaohancai diaohancai requested a review from imbajin January 5, 2024 07:19
@javeme
Copy link
Contributor

javeme commented Jan 13, 2024

Note the CI failed

@imbajin imbajin merged commit ad2240a into apache:master Jan 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants