Fix MiniKubeTest.testJobCancelled #287
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #287 +/- ##
============================================
+ Coverage 85.03% 85.12% +0.08%
- Complexity 3246 3280 +34
============================================
Files 345 349 +4
Lines 12298 12406 +108
Branches 1102 1113 +11
============================================
+ Hits 10458 10560 +102
- Misses 1315 1316 +1
- Partials 525 530 +5 ☔ View full report in Codecov by Sentry. |
imbajin
reviewed
Nov 22, 2023
.github/workflows/ci.yml
Outdated
| @@ -45,7 +45,7 @@ jobs: | |||
| with: | |||
| path: ~/hadoop-3.3.2.tar.gz | |||
| key: ${{ runner.os }}--hadoop | |||
| restore-keys: ${{ runner.os }}-hadoop | |||
| restore-keys: ${{ runner.os }}--hadoop | |||
javeme
reviewed
Nov 23, 2023
| @@ -246,6 +246,7 @@ public void testJobCancelled() { | |||
| jobState.jobStatus(JobStatus.INITIALIZING); | |||
| Mockito.verify(jobObserver, Mockito.timeout(15000L).atLeast(1)) | |||
| .onJobStateChanged(Mockito.eq(jobState)); | |||
| Mockito.clearInvocations(jobObserver); | |||
|
|
|||
| this.driver.cancelJob(jobId, params); | |||
There was a problem hiding this comment.
should we also assert the returned value of cancelJob()
| @@ -246,6 +246,7 @@ public void testJobCancelled() { | |||
| jobState.jobStatus(JobStatus.INITIALIZING); | |||
| Mockito.verify(jobObserver, Mockito.timeout(15000L).atLeast(1)) | |||
| .onJobStateChanged(Mockito.eq(jobState)); | |||
| Mockito.clearInvocations(jobObserver); | |||
There was a problem hiding this comment.
there is still an error:
Error: Failures:
Error: MiniKubeTest.testJobCancelled:258
Argument(s) are different! Wanted:
jobObserver.onJobStateChanged(
org.apache.hugegraph.computer.driver.DefaultJobState@393365e0
);
-> at org.apache.hugegraph.computer.k8s.MiniKubeTest.testJobCancelled(MiniKubeTest.java:258)
Actual invocations have different arguments:
jobObserver.onJobStateChanged(
org.apache.hugegraph.computer.driver.DefaultJobState@3089df23
);
-> at org.apache.hugegraph.computer.k8s.driver.KubernetesDriver$1.eventReceived(KubernetesDriver.java:344)
jobObserver.onJobStateChanged(
org.apache.hugegraph.computer.driver.DefaultJobState@3089df23
);
-> at org.apache.hugegraph.computer.k8s.driver.KubernetesDriver$1.eventReceived(KubernetesDriver.java:344)
[INFO]
Error: Tests run: 565, Failures: 1, Errors: 0, Skipped: 0| @@ -246,6 +246,7 @@ public void testJobCancelled() { | |||
| jobState.jobStatus(JobStatus.INITIALIZING); | |||
| Mockito.verify(jobObserver, Mockito.timeout(15000L).atLeast(1)) | |||
| .onJobStateChanged(Mockito.eq(jobState)); | |||
| Mockito.clearInvocations(jobObserver); | |||
|
|
|||
| this.driver.cancelJob(jobId, params); | |||
|
|
|||
There was a problem hiding this comment.
try to sleep() both before and after cancelJob?
sleep(1s)
cancelJob()
sleep(2s)
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
Main Changes
Trying to fix MiniKubeTest.testJobCancelled
Verifying these changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODODoc - DoneDoc - No Need