Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(k8s): Add MinIO as internal(default) storage #272

Merged
merged 2 commits into from
Oct 28, 2023
Merged

feat(k8s): Add MinIO as internal(default) storage #272

merged 2 commits into from
Oct 28, 2023

Conversation

Radeity
Copy link
Member

@Radeity Radeity commented Oct 23, 2023 •
edited
Loading

Purpose of the PR

Main Changes

  • Deploy a standalone MinIO instance, and mount to local volume.

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows.
  • Have to add UT in future PR.

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #272 (4941908) into master (2e45cd2) will decrease coverage by 0.11%.
The diff coverage is 22.22%.

@@             Coverage Diff              @@
##             master     #272      +/-   ##
============================================
- Coverage     85.10%   85.00%   -0.11%     
- Complexity     3245     3246       +1     
============================================
  Files           345      345              
  Lines         12283    12298      +15     
  Branches       1101     1102       +1     
============================================
  Hits          10454    10454              
- Misses         1303     1317      +14     
- Partials        526      527       +1
Files Coverage Δ
...ugegraph/computer/core/config/ComputerOptions.java 98.94% <ø> (ø)
.../computer/k8s/operator/config/OperatorOptions.java 100.00% <100.00%> (ø)
...r/k8s/operator/controller/ComputerJobDeployer.java 86.14% <100.00%> (+0.07%) ⬆️
...egraph/computer/core/snapshot/SnapshotManager.java 14.07% <0.00%> (-2.87%) ⬇️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

javeme
javeme reviewed Oct 25, 2023
View reviewed changes
Copy link
Contributor

@javeme javeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Radeity
Copy link
Member Author

Radeity commented Oct 25, 2023

Would you like to help double check when available? @coderzc

coderzc
coderzc approved these changes Oct 28, 2023
View reviewed changes
Copy link
Member

@coderzc coderzc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coderzc coderzc requested a review from javeme October 28, 2023 09:34
@coderzc
Copy link
Member

coderzc commented Oct 28, 2023

@javeme Please approve this PR if you don't have any other comments.

@javeme javeme merged commit ff85e34 into apache:master Oct 28, 2023
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderzc coderzc coderzc approved these changes

@javeme javeme javeme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Add MinIO as internal(default) storage
3 participants
@Radeity @coderzc @javeme