Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update PULL_REQUEST_TEMPLATE.md #257

Merged
merged 3 commits into from
Jun 25, 2023
Merged

chore: update PULL_REQUEST_TEMPLATE.md #257

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6fe7925
Update PULL_REQUEST_TEMPLATE.md
Radeity Jun 21, 2023
a921dbc
Update .github/PULL_REQUEST_TEMPLATE.md
Radeity Jun 22, 2023
90e556c
Update PULL_REQUEST_TEMPLATE.md
Radeity Jun 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 7 additions & 15 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

## Purpose of the PR

- close: xxx <!-- or use "fix: xxx", "xxx" is the link of related issue -->
- close #xxx <!-- or use "fix #xxx", "xxx" is the ID-link of related issue, e.g: close #257 -->

<!--
Please explain more context in this section, clarify why the changes are needed.
Expand All @@ -38,20 +38,12 @@ For example:

## Verifying these changes

<!-- Please pick either of the following options -->
<!-- Please pick the proper options below -->

- This change is a trivial rework / code cleanup without any test coverage.

*(or)*

- This change is already covered by existing tests, such as *(please describe tests)*.

*(or)*

- This change added tests and can be verified as follows:

*(for example:)*
- *Add UT.*
- [ ] Trivial rework / code cleanup without any test coverage. (No Need)
- [ ] Already covered by existing tests, such as *(please modify tests here)*.
- [ ] Need tests and can be verified as follows:
- xxx
Radeity marked this conversation as resolved.
Show resolved Hide resolved


## Does this PR potentially affect the following parts?
Expand All @@ -70,4 +62,4 @@ For example:

- [ ] `Doc - TODO` <!-- Your PR changes impact docs and you will update later -->
- [ ] `Doc - Done` <!-- Related docs have been already added or updated -->
- [ ] `Doc - NO Need` <!-- Your PR changes don't impact/need docs -->
- [ ] `Doc - No Need` <!-- Your PR changes don't impact/need docs -->