chore: add apache-release.sh & prepare release #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderzc
force-pushed
the
before-release
branch
from
0bc76a9 to
90154aa
Compare
Codecov Report
@@ Coverage Diff @@
## master #218 +/- ##
=========================================
Coverage 85.74% 85.74%
+ Complexity 3231 3230 -1
=========================================
Files 344 344
Lines 12079 12079
Branches 1087 1087
=========================================
Hits 10357 10357
+ Misses 1195 1194 -1
- Partials 527 528 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
imbajin
force-pushed
the
before-release
branch
from
f9bff17 to
4fb79be
Compare
coderzc
force-pushed
the
before-release
branch
2 times, most recently
from
8458545 to
3a111d7
Compare
imbajin
commented
Dec 8, 2022
14 tasks
coderzc
changed the title
coderzc
previously approved these changes
Dec 9, 2022
coderzc
force-pushed
the
before-release
branch
from
04871ec to
c38695d
Compare
imbajin
commented
Dec 9, 2022
| # git release branch (check it carefully) | ||
| GIT_BRANCH="release-${RELEASE_VERSION}" | ||
| GIT_BRANCH="$(git branch --show-current)" |
There was a problem hiding this comment.
seems a little dangerous when upload with a wrong branch? or check the branch-name below?
imbajin
commented
Dec 9, 2022
.gitattributes
Outdated
| assembly/ export-ignore | ||
| computer-dist/src/assembly/ export-ignore | ||
| computer-k8s-operator/crd-generate/bin/ export-ignore | ||
| logs/ export-ignore |
There was a problem hiding this comment.
if logs ignored in .gitignore already, it won't be packaged by default
imbajin
force-pushed
the
before-release
branch
from
c38695d to
25e771a
Compare
imbajin
commented
Dec 10, 2022
imbajin
commented
Dec 10, 2022
imbajin
commented
Dec 10, 2022
| if [ "$USERNAME" = "" ]; then | ||
| svn commit -m "submit files for ${REPO} ${RELEASE_VERSION}" | ||
| else | ||
| svn commit -m "submit files for ${REPO} ${RELEASE_VERSION}" --username ${USERNAME} --password ${PASSWORD} |
There was a problem hiding this comment.
- double quota for $username & $password
- use 2 spaces instead of 4 before
svn
if [ "$USERNAME" = "" ]; then
svn commit -m "submit files for ${REPO} ${RELEASE_VERSION}"
else
svn commit -m "submit files for ${REPO} ${RELEASE_VERSION}" --username "${USERNAME}" --password "${PASSWORD}"
fi
|
|
coderzc
force-pushed
the
before-release
branch
2 times, most recently
from
da3dbce to
08c1b6a
Compare
coderzc
force-pushed
the
before-release
branch
2 times, most recently
from
a0bf049 to
3360aaf
Compare
coderzc
previously approved these changes
Dec 15, 2022
imbajin
force-pushed
the
before-release
branch
from
3360aaf to
e806302
Compare
|
update the commit log & use |
Linary
approved these changes
Dec 15, 2022
zyxxoo
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use rebase merge to keep the commit after #217
Remember rename current branch to
release-1.0.0first (for script running):git branch -m before-release release-1.0.0and @coderzc keep test & update the script (ammend to the 4th commit) to keep commit clean
other chore: