Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support check license header with RAT #191

Merged
merged 10 commits into from
Nov 22, 2022

Conversation

z7658329
Copy link
Member

support check license header with RAT

javeme
javeme previously approved these changes Oct 30, 2022
@codecov
Copy link

codecov bot commented Oct 30, 2022

Codecov Report

Merging #191 (31764fe) into master (86e548c) will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #191      +/-   ##
============================================
+ Coverage     86.01%   86.03%   +0.02%     
+ Complexity     3207     3206       -1     
============================================
  Files           341      341              
  Lines         12197    12197              
  Branches       1085     1085              
============================================
+ Hits          10491    10494       +3     
+ Misses         1183     1179       -4     
- Partials        523      524       +1     
Impacted Files Coverage Δ
...puter/core/network/netty/AbstractNettyHandler.java 47.50% <ø> (ø)
...idu/hugegraph/computer/core/util/ShutdownHook.java 44.44% <ø> (ø)
...h/computer/core/network/session/ClientSession.java 81.96% <0.00%> (-2.46%) ⬇️
...k8s/operator/controller/ComputerJobController.java 89.72% <0.00%> (+1.02%) ⬆️
...com/baidu/hugegraph/computer/core/bsp/BspBase.java 100.00% <0.00%> (+7.69%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

pom.xml Outdated Show resolved Hide resolved
imbajin
imbajin previously approved these changes Oct 31, 2022
@z7658329
Copy link
Member Author

@coderzc
Copy link
Member

coderzc commented Oct 31, 2022

still have some problems, @coderzc https://app.travis-ci.com/github/apache/incubator-hugegraph-computer/builds/257244354

image

@imbajin Can we remove travis-Ci?

coderzc
coderzc previously approved these changes Oct 31, 2022
@z7658329 z7658329 dismissed stale reviews from coderzc and imbajin via 97086a9 October 31, 2022 11:20
@imbajin
Copy link
Member

imbajin commented Oct 31, 2022

@imbajin Can we remove travis-Ci?

after #190 merged, the travis-CI will disappear

@z7658329
Copy link
Member Author

z7658329 commented Nov 1, 2022

is there something wrong? the last commit only remove unused code @coderzc
image

@imbajin
Copy link
Member

imbajin commented Nov 1, 2022

is there something wrong? the last commit only remove unused code @coderzc
image

try rerun it,network may bad sometime

imbajin
imbajin previously approved these changes Nov 1, 2022
@imbajin
Copy link
Member

imbajin commented Nov 1, 2022

@coderzc seems u need to update the prepare shell (adopt the latest loader code)

image

@coderzc coderzc added this to the 1.0.0 milestone Nov 20, 2022
@coderzc coderzc requested review from imbajin and javeme November 22, 2022 13:29
@imbajin imbajin changed the title support check license header with RAT chore: support check license header with RAT Nov 22, 2022
@imbajin imbajin merged commit a658f3d into apache:master Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants