Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update a string of ci configs & gitignore & README #189

Merged
merged 5 commits into from
Nov 1, 2022
Merged

Conversation

imbajin
Copy link
Member

@imbajin imbajin commented Oct 26, 2022

also fix typo

@imbajin imbajin added the enhancement New feature or request label Oct 26, 2022
@imbajin imbajin requested review from Linary and coderzc October 26, 2022 11:50
@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #189 (9cd9b90) into master (1800517) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 9cd9b90 differs from pull request most recent head 31e24d4. Consider uploading reports for the commit 31e24d4 to get more accurate results

@@             Coverage Diff              @@
##             master     #189      +/-   ##
============================================
- Coverage     86.12%   86.10%   -0.02%     
+ Complexity     3212     3210       -2     
============================================
  Files           341      341              
  Lines         12200    12200              
  Branches       1085     1085              
============================================
- Hits          10507    10505       -2     
  Misses         1171     1171              
- Partials        522      524       +2     
Impacted Files Coverage Δ
...hugegraph/computer/core/network/TransportUtil.java 88.57% <0.00%> (-2.86%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@@ -7,7 +7,7 @@ on:
branches: [ master, release-*, v0.* ]
pull_request:
# The branches below must be a subset of the branches above
branches: [ master ]
# branches: [ master ] # enable it in all PR
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

branches=empty means any pr? if so please update the comment at line 9

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

- /^v[0-9]\..*$/
pull_request:
branches:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

means any branch if keep none?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

README.md Outdated
The [project homepage](https://hugegraph.apache.org/docs/) contains more information about hugegraph-computer.

And here are links of other repositories:
1. [hugegraph-server](https://github.com/apache/incubator-hugegraph) (graph's core component - OLTP server)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@imbajin imbajin requested a review from javeme October 26, 2022 15:30
@imbajin
Copy link
Member Author

imbajin commented Nov 1, 2022

@coderzc after this PR merged, travis CI will disappear

Comment on lines 1 to 4
name: publish hugegraph-computer images

# TODO: could we use this action now? (if not, what shall we do?)
on:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we couldn't use it due to lack (apache) permission, so just disable it manually (consider someway to use it)

@imbajin imbajin changed the title chore: update a string of ci configs & gitignore & REAME chore: update a string of ci configs & gitignore & README Nov 1, 2022
@imbajin imbajin merged commit a99ddd6 into master Nov 1, 2022
@imbajin imbajin deleted the ci branch November 1, 2022 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants