feat: support cluster coefficient algorithm #108

imbajin · 2021-09-28T13:55:21Z

better add more test case (multi increase graph) & refactor later, the doc for it will attach in wiki first

Not redy for review: wait test stable & refact it later

better add more test case (multi increase graph)

codecov · 2021-09-28T14:55:43Z

Codecov Report

Merging #108 (eace58a) into master (b796128) will decrease coverage by 0.17%.
The diff coverage is 66.03%.

@@             Coverage Diff              @@
##             master     #108      +/-   ##
============================================
- Coverage     87.94%   87.77%   -0.18%     
- Complexity     2827     2858      +31     
============================================
  Files           295      301       +6     
  Lines         10630    10749     +119     
  Branches        900      912      +12     
============================================
+ Hits           9349     9435      +86     
- Misses          854      881      +27     
- Partials        427      433       +6

Impacted Files	Coverage Δ
.../algorithm/centrality/degree/DegreeCentrality.java	`70.96% <0.00%> (-0.91%)`	⬇️
...rithm/community/cc/ClusteringCoefficientValue.java	`0.00% <0.00%> (ø)`
.../algorithm/community/cc/ClusteringCoefficient.java	`89.79% <89.79%> (ø)`
...ithm/community/cc/ClusteringCoefficientOutput.java	`100.00% <100.00%> (ø)`
...ithm/community/cc/ClusteringCoefficientParams.java	`100.00% <100.00%> (ø)`
...mputer/k8s/operator/common/AbstractController.java	`84.34% <0.00%> (-0.51%)`	⬇️
...egraph/computer/core/sort/sorting/SortManager.java	`80.00% <0.00%> (ø)`
...ph/computer/core/sort/sorting/RecvSortManager.java	`100.00% <0.00%> (ø)`
...ph/computer/core/sort/sorting/SendSortManager.java	`100.00% <0.00%> (ø)`
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b796128...eace58a. Read the comment docs.

...ain/java/com/baidu/hugegraph/computer/algorithm/community/cc/ClusteringCoefficientValue.java

javeme · 2021-11-04T03:44:43Z

...in/java/com/baidu/hugegraph/computer/algorithm/community/cc/ClusteringCoefficientOutput.java

+    }
+
+    @Override
+    public com.baidu.hugegraph.structure.graph.Vertex constructHugeVertex(


prefer to override value() method

...ain/java/com/baidu/hugegraph/computer/algorithm/community/cc/ClusteringCoefficientValue.java

github-actions · 2021-12-04T21:10:52Z

Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label

github-actions · 2022-07-04T21:03:13Z

Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label

imbajin · 2022-10-21T05:51:35Z

I'll address it soon

imbajin · 2022-10-31T11:25:19Z

some improve code could do it later (this PR only focus the CI pass)

then we could start rename package & adopt the dependencies soon

...src/main/java/com/baidu/hugegraph/computer/algorithm/community/cc/ClusteringCoefficient.java

…ph-computer into cc-algo

…c-algo

...src/main/java/com/baidu/hugegraph/computer/algorithm/community/cc/ClusteringCoefficient.java

javeme · 2022-11-02T15:20:17Z

...in/java/com/baidu/hugegraph/computer/algorithm/community/cc/ClusteringCoefficientOutput.java

+        return hugeVertex;
+    }
+
+    /* TODO: enhance it


unused code?

useful, maybe use it in next PR (but not this time)

...ain/java/com/baidu/hugegraph/computer/algorithm/community/cc/ClusteringCoefficientValue.java

imbajin · 2022-11-07T15:29:42Z

merge it after #194

imbajin · 2022-11-22T14:23:12Z

…ph-computer into pr/108

...in/java/com/baidu/hugegraph/computer/algorithm/community/cc/ClusteringCoefficientOutput.java

coderzc · 2022-11-22T14:48:39Z

...in/java/com/baidu/hugegraph/computer/algorithm/community/cc/ClusteringCoefficientOutput.java

@@ -48,7 +48,7 @@ protected org.apache.hugegraph.structure.graph.Vertex constructHugeVertex(Vertex
        org.apache.hugegraph.structure.graph.Vertex hugeVertex =
                new org.apache.hugegraph.structure.graph.Vertex(null);
        hugeVertex.id(vertex.id().asObject());
-        float triangle = ((ClusteringCoefficientValue) vertex.value()).count();
+        long triangle = ((ClusteringCoefficientValue) vertex.value()).count();
        int degree = ((ClusteringCoefficientValue) vertex.value()).idList().size();
        hugeVertex.property(this.name(), 2 * triangle / degree / (degree - 1));


Keep floating point type?

codecov · 2022-11-22T15:06:01Z

Codecov Report

Merging #108 (fe68e84) into master (86e548c) will increase coverage by 0.01%.
The diff coverage is 89.42%.

@@             Coverage Diff              @@
##             master     #108      +/-   ##
============================================
+ Coverage     86.01%   86.03%   +0.01%     
- Complexity     3207     3237      +30     
============================================
  Files           341      345       +4     
  Lines         12197    12292      +95     
  Branches       1085     1097      +12     
============================================
+ Hits          10491    10575      +84     
- Misses         1183     1187       +4     
- Partials        523      530       +7

Impacted Files	Coverage Δ
...idu/hugegraph/computer/core/graph/value/Value.java	`78.57% <ø> (ø)`
...ugegraph/computer/core/config/ComputerOptions.java	`100.00% <ø> (ø)`
...puter/core/network/netty/AbstractNettyHandler.java	`47.50% <ø> (ø)`
...idu/hugegraph/computer/core/util/ShutdownHook.java	`44.44% <ø> (ø)`
.../algorithm/centrality/degree/DegreeCentrality.java	`65.51% <33.33%> (-2.23%)`	⬇️
...rithm/community/cc/ClusteringCoefficientValue.java	`83.33% <83.33%> (ø)`
.../algorithm/community/cc/ClusteringCoefficient.java	`89.79% <89.79%> (ø)`
...ithm/community/cc/ClusteringCoefficientOutput.java	`100.00% <100.00%> (ø)`
...ithm/community/cc/ClusteringCoefficientParams.java	`100.00% <100.00%> (ø)`
...hm/community/trianglecount/TriangleCountValue.java	`100.00% <100.00%> (ø)`
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

imbajin force-pushed the cc-algo branch from dae9bd3 to ef07fbd Compare September 28, 2021 14:18

feat: support local cluster coefficient algorithm

eace58a

better add more test case (multi increase graph)

imbajin force-pushed the cc-algo branch from ef07fbd to eace58a Compare September 28, 2021 14:33

coderzc previously approved these changes Oct 14, 2021

View reviewed changes

...ain/java/com/baidu/hugegraph/computer/algorithm/community/cc/ClusteringCoefficientValue.java Outdated Show resolved Hide resolved

javeme reviewed Nov 4, 2021

View reviewed changes

github-actions bot added the inactive label Dec 4, 2021

github-actions bot closed this Jun 3, 2022

imbajin reopened this Jun 4, 2022

imbajin added feature New feature and removed inactive labels Jun 4, 2022

github-actions bot added the inactive label Jul 4, 2022

imbajin self-assigned this Oct 21, 2022

imbajin added 3 commits October 31, 2022 18:54

set max line to 100

ce8b780

Merge branch 'master' into cc-algo

2896ca0

refactor with master

9346311

imbajin dismissed coderzc’s stale review via 9346311 October 31, 2022 11:21

imbajin marked this pull request as ready for review October 31, 2022 11:22

imbajin requested a review from coderzc October 31, 2022 11:23

remove unused imports

108ca35

imbajin mentioned this pull request Oct 31, 2022

[Summary] computer release v1.0 todo list #188

Closed

14 tasks

javeme reviewed Oct 31, 2022

View reviewed changes

...src/main/java/com/baidu/hugegraph/computer/algorithm/community/cc/ClusteringCoefficient.java Outdated Show resolved Hide resolved

imbajin added 4 commits November 1, 2022 16:44

Merge branch 'master' into cc-algo

818a4a4

tiny fix

59befac

Merge branch 'cc-algo' of https://github.com/apache/incubator-hugegra…

31bade9

…ph-computer into cc-algo

Update ClusteringCoefficientTest.java

03455bb

imbajin added 2 commits November 1, 2022 17:07

Merge branch 'master' into cc-algo

2b539a4

Merge branch 'cc-algo' of github.com:apache/hugegraph-computer into c…

44cd8ae

…c-algo

github-actions bot removed the inactive label Nov 1, 2022

javeme reviewed Nov 2, 2022

View reviewed changes

tiny improve

268d91f

javeme previously approved these changes Nov 3, 2022

View reviewed changes

imbajin added 2 commits November 22, 2022 21:18

Merge branch 'master' into cc-algo

d8b4e48

adapt apache version v1.0.0

0d401d6

imbajin dismissed javeme’s stale review via 0d401d6 November 22, 2022 13:42

Merge branch 'master' into cc-algo

82b334a

imbajin requested a review from javeme November 22, 2022 13:53

Merge branch 'master' into cc-algo

03f8d6b

coderzc previously approved these changes Nov 22, 2022

View reviewed changes

imbajin added 2 commits November 22, 2022 22:31

replace value class

2aaf827

Merge branch 'cc-algo' of https://github.com/apache/incubator-hugegra…

3a25b0d

…ph-computer into pr/108

imbajin dismissed coderzc’s stale review via 3a25b0d November 22, 2022 14:36

coderzc reviewed Nov 22, 2022

View reviewed changes

...in/java/com/baidu/hugegraph/computer/algorithm/community/cc/ClusteringCoefficientOutput.java Outdated Show resolved Hide resolved

change to long result

de7f97c

coderzc reviewed Nov 22, 2022

View reviewed changes

Update ClusteringCoefficientOutput.java

fe68e84

javeme approved these changes Nov 22, 2022

View reviewed changes

coderzc approved these changes Nov 22, 2022

View reviewed changes

imbajin merged commit 8b7dbd6 into master Nov 23, 2022

imbajin deleted the cc-algo branch November 23, 2022 03:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: support cluster coefficient algorithm #108

feat: support cluster coefficient algorithm #108

imbajin commented Sep 28, 2021 •

edited

Loading

codecov bot commented Sep 28, 2021

javeme Nov 4, 2021

github-actions bot commented Dec 4, 2021

github-actions bot commented Jul 4, 2022

imbajin commented Oct 21, 2022

imbajin commented Oct 31, 2022 •

edited

Loading

javeme Nov 2, 2022

imbajin Nov 3, 2022

imbajin commented Nov 7, 2022

imbajin commented Nov 22, 2022

coderzc Nov 22, 2022

imbajin Nov 22, 2022

codecov bot commented Nov 22, 2022

feat: support cluster coefficient algorithm #108

feat: support cluster coefficient algorithm #108

Conversation

imbajin commented Sep 28, 2021 • edited Loading

codecov bot commented Sep 28, 2021

Codecov Report

javeme Nov 4, 2021

Choose a reason for hiding this comment

github-actions bot commented Dec 4, 2021

github-actions bot commented Jul 4, 2022

imbajin commented Oct 21, 2022

imbajin commented Oct 31, 2022 • edited Loading

javeme Nov 2, 2022

Choose a reason for hiding this comment

imbajin Nov 3, 2022

Choose a reason for hiding this comment

imbajin commented Nov 7, 2022

imbajin commented Nov 22, 2022

coderzc Nov 22, 2022

Choose a reason for hiding this comment

imbajin Nov 22, 2022

Choose a reason for hiding this comment

codecov bot commented Nov 22, 2022

Codecov Report

imbajin commented Sep 28, 2021 •

edited

Loading

imbajin commented Oct 31, 2022 •

edited

Loading