add some test cases for util package #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I39b457c2a7a338a909b3aa0ba8ff4a8b5057b339
|
Before adding test cases: |
Codecov Report
@@ Coverage Diff @@
## master #70 +/- ##
============================================
+ Coverage 85.08% 87.61% +2.53%
- Complexity 793 829 +36
============================================
Files 61 61
Lines 2299 2326 +27
Branches 341 352 +11
============================================
+ Hits 1956 2038 +82
+ Misses 192 147 -45
+ Partials 151 141 -10
Continue to review full report at Codecov.
|
|
After adding test cases: |
Linary
requested changes
Apr 7, 2021
| List<T> list = new ArrayList<>(original); | ||
| if (to == -1) { | ||
| if (from < 0) { | ||
| E.checkArgument(from >= 0, |
There was a problem hiding this comment.
if seems unnecessary, consider for perf? If so, add a comment
There was a problem hiding this comment.
to keep same style with "if (to < 0)"
Change-Id: Id95c4e2e5b9f4453d57750470fc54d58ec6531d9
corgiboygsj
previously approved these changes
Apr 12, 2021
houzhizhen
reviewed
Apr 12, 2021
| if (to == -1) { | ||
| E.checkArgument(from >= 0, | ||
| "Invalid from parameter of subSet(): %s", from); | ||
| if (to < 0) { |
There was a problem hiding this comment.
"if (to < 0)" => "if (to < from)". IllegalArgumentException will be thrown if to < from。
Change-Id: I32d83f5738250eca23ae16c2ccbf52059a874bf6
houzhizhen
approved these changes
Apr 12, 2021
Linary
approved these changes
Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I39b457c2a7a338a909b3aa0ba8ff4a8b5057b339