New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement PausableScheduledThreadPool #61

Merged

javeme merged 8 commits into master from pausable-schedule-threadpool

Feb 3, 2021

Contributor

Linary commented Jan 21, 2021

No description provided.


          Implement PausableScheduledThreadPool

148bd95

codecov bot commented Jan 22, 2021 •

edited

Loading

Codecov Report

Merging #61 (350a65f) into master (f4e861b) will decrease coverage by 0.00%.
The diff coverage is 90.62%.

@@             Coverage Diff              @@
##             master      #61      +/-   ##
============================================
- Coverage     84.69%   84.69%   -0.01%     
- Complexity      746      756      +10     
============================================
  Files            58       59       +1     
  Lines          2150     2182      +32     
  Branches        320      321       +1     
============================================
+ Hits           1821     1848      +27     
- Misses          187      190       +3     
- Partials        142      144       +2

Impacted Files	Coverage Δ	Complexity Δ
...egraph/concurrent/PausableScheduledThreadPool.java	`88.88% <88.88%> (ø)`	`9.00 <9.00> (?)`
...in/java/com/baidu/hugegraph/util/ExecutorUtil.java	`87.50% <100.00%> (+5.68%)`	`5.00 <2.00> (+2.00)`
...c/main/java/com/baidu/hugegraph/util/DateUtil.java	`76.00% <0.00%> (-8.00%)`	`9.00% <0.00%> (-1.00%)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4e861b...350a65f. Read the comment docs.

javeme reviewed

View reviewed changes

src/main/java/com/baidu/hugegraph/threadpool/PausableScheduledThreadPool.java Outdated Show resolved Hide resolved

src/main/java/com/baidu/hugegraph/threadpool/PausableScheduledThreadPool.java Outdated Show resolved Hide resolved

src/main/java/com/baidu/hugegraph/threadpool/PausableScheduledThreadPool.java Outdated Show resolved Hide resolved


          tiny improve

82ef32b

javeme reviewed

View reviewed changes

src/main/java/com/baidu/hugegraph/threadpool/PausableScheduledThreadPool.java Outdated

                       this.paused = false;
-                      this.notifyAll();
+                      synchronized (this) {

Contributor

javeme Jan 22, 2021

move this.paused = false; into synchronized block to avoid race between resumeSchedule and resumeSchedule

src/main/java/com/baidu/hugegraph/threadpool/PausableScheduledThreadPool.java Outdated

    
                  protected synchronized void beforeExecute(Thread t, Runnable r) {

                      if (this.paused) {

                  protected void beforeExecute(Thread t, Runnable r) {

                      synchronized (this) {

Contributor

javeme Jan 22, 2021

keep all paused writing synchronized


          tiny improve

7ca72ca

javeme previously approved these changes

View reviewed changes

houzhizhen previously approved these changes

View reviewed changes

zhoney previously approved these changes

View reviewed changes


          tiny improve

618678a

Linary dismissed stale reviews from zhoney, houzhizhen, and javeme via

618678a

January 30, 2021 11:46

javeme previously approved these changes

View reviewed changes

houzhizhen reviewed

View reviewed changes

src/test/java/com/baidu/hugegraph/unit/threadpool/PausableScheduledThreadPoolTest.java Outdated

+                          System.out.println("counter: " + counter.incrementAndGet());
+                      }, 2, 2, TimeUnit.SECONDS);
+                      Thread.sleep(4500);

Contributor

houzhizhen Feb 1, 2021

4500L

src/test/java/com/baidu/hugegraph/unit/threadpool/PausableScheduledThreadPoolTest.java Outdated

+                      AtomicInteger counter = new AtomicInteger(0);
+                      executor.scheduleWithFixedDelay(() -> {
+                          System.out.println("counter: " + counter.incrementAndGet());
+                      }, 2, 2, TimeUnit.SECONDS);

Contributor

houzhizhen Feb 1, 2021

2, 2 -> 2L, 2L

src/test/java/com/baidu/hugegraph/unit/threadpool/PausableScheduledThreadPoolTest.java Outdated

+                      // pause
+                      executor.pauseSchedule();
+                      Thread.sleep(2000);

Contributor

houzhizhen Feb 1, 2021

2000L

src/test/java/com/baidu/hugegraph/unit/threadpool/PausableScheduledThreadPoolTest.java Outdated

+                      // resume
+                      executor.resumeSchedule();
+                      Thread.sleep(2000);

Contributor

houzhizhen Feb 1, 2021

2000L

src/test/java/com/baidu/hugegraph/unit/threadpool/PausableScheduledThreadPoolTest.java Outdated

+                      AtomicInteger counter = new AtomicInteger(0);
+                      executor.scheduleAtFixedRate(() -> {
+                          System.out.println("counter: " + counter.incrementAndGet());
+                      }, 2, 2, TimeUnit.SECONDS);

Contributor

houzhizhen Feb 1, 2021

ditto

src/test/java/com/baidu/hugegraph/unit/threadpool/PausableScheduledThreadPoolTest.java Outdated

+                      executor.scheduleAtFixedRate(() -> {
+                          System.out.println("counter: " + counter.incrementAndGet());
+                      }, 2, 2, TimeUnit.SECONDS);
+                      Thread.sleep(4500);

Contributor

houzhizhen Feb 1, 2021

ditto

src/test/java/com/baidu/hugegraph/unit/threadpool/PausableScheduledThreadPoolTest.java Outdated

+                      // pause
+                      executor.pauseSchedule();
+                      Thread.sleep(2000);

Contributor

houzhizhen Feb 1, 2021

ditto

src/test/java/com/baidu/hugegraph/unit/threadpool/PausableScheduledThreadPoolTest.java Outdated

+                      // resume
+                      executor.resumeSchedule();
+                      Thread.sleep(2000);

Contributor

houzhizhen Feb 1, 2021

ditto

src/test/java/com/baidu/hugegraph/unit/threadpool/PausableScheduledThreadPoolTest.java Outdated

+                      executor.pauseSchedule();
+                      executor.shutdownNow();
+                      executor.awaitTermination(3, TimeUnit.SECONDS);

Contributor

houzhizhen Feb 1, 2021

ditto


          tiny improve

638466a

Linary dismissed javeme’s stale review via

638466a

February 1, 2021 08:15

houzhizhen previously approved these changes

View reviewed changes

javeme approved these changes

View reviewed changes

zhoney previously approved these changes

View reviewed changes

javeme requested changes

View reviewed changes

src/main/java/com/baidu/hugegraph/threadpool/PausableScheduledThreadPool.java Outdated Show resolved Hide resolved

src/test/java/com/baidu/hugegraph/unit/threadpool/PausableScheduledThreadPoolTest.java Outdated Show resolved Hide resolved

Linary dismissed stale reviews from zhoney and houzhizhen via

55864c3

February 2, 2021 06:03


          move to concurrent package

978b157

Linary force-pushed the pausable-schedule-threadpool branch from 55864c3 to 978b157 Compare

February 2, 2021 06:09

zhoney previously approved these changes

View reviewed changes

Contributor

javeme commented Feb 2, 2021

ci error


          use period to improve test case

eb9746a

Linary dismissed zhoney’s stale review via

eb9746a

February 2, 2021 13:22

javeme previously approved these changes

View reviewed changes

zhoney requested changes

View reviewed changes

src/test/java/com/baidu/hugegraph/unit/UnitTestSuite.java Outdated

-                  LicenseVerifyParamTest.class,
-                  MachineInfoTest.class,
-                  LicenseManagerTest.class,
+              //    LockManagerTest.class,

Contributor

zhoney Feb 3, 2021

keep origin


          tiny improve

350a65f

Linary dismissed javeme’s stale review via

350a65f

February 3, 2021 13:41

zhoney approved these changes

View reviewed changes

javeme approved these changes

View reviewed changes

javeme merged commit c80f959 into master

javeme deleted the pausable-schedule-threadpool branch

February 3, 2021 14:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet