add api for setting thread pool name #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6 +/- ##
==========================================
+ Coverage 22.75% 22.97% +0.22%
==========================================
Files 42 43 +1
Lines 1257 1262 +5
Branches 227 227
==========================================
+ Hits 286 290 +4
- Misses 943 944 +1
Partials 28 28
Continue to review full report at Codecov.
|
Linary
reviewed
Oct 19, 2018
| ThreadFactory factory = new BasicThreadFactory.Builder() | ||
| .namingPattern(name) | ||
| .build(); | ||
| return java.util.concurrent.Executors.newFixedThreadPool(size, factory); |
There was a problem hiding this comment.
why not import java.util.concurrent.Executors
Change-Id: I93aeddc6783e6b03d2aa31aa8ca42059e253ba81
Linary
approved these changes
Oct 19, 2018
zhoney
approved these changes
Oct 22, 2018
zhoney
approved these changes
Oct 22, 2018
zhoney
approved these changes
Oct 22, 2018
zhoney
approved these changes
Oct 22, 2018
zhoney
approved these changes
Oct 22, 2018
zhoney
approved these changes
Oct 22, 2018
zhoney
approved these changes
Oct 22, 2018
zhoney
approved these changes
Oct 22, 2018
zhoney
approved these changes
Oct 22, 2018
zhoney
approved these changes
Oct 22, 2018
zhoney
approved these changes
Oct 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I93aeddc6783e6b03d2aa31aa8ca42059e253ba81