refactor RestClient as interface #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ib7153dc7b8d3bf3df9d19662b54cb05ff14c032b
Codecov Report
@@ Coverage Diff @@
## master #49 +/- ##
============================================
+ Coverage 81.73% 81.85% +0.11%
- Complexity 685 686 +1
============================================
Files 57 57
Lines 2075 2083 +8
Branches 303 304 +1
============================================
+ Hits 1696 1705 +9
Misses 250 250
+ Partials 129 128 -1
Continue to review full report at Codecov.
|
Change-Id: I57dd2db3c1b472403967f0b133ddb34c8f0edf48
javeme
force-pushed
the
rest-client-interface
branch
from
2c49822 to
2b78aee
Compare
houzhizhen
previously approved these changes
Jun 18, 2020
shzcore
suggested changes
Jun 18, 2020
| } | ||
|
|
||
| public AbstractRestClient(String url, String user, String password, int timeout, | ||
| int maxTotal, int maxPerRoute) { |
| } | ||
|
|
||
| public AbstractRestClient(String url, String user, String password, int timeout, | ||
| int maxTotal, int maxPerRoute, String protocol, |
shzcore
previously approved these changes
Jun 18, 2020
zhoney
requested changes
Jun 19, 2020
| public abstract class AbstractRestClient implements RestClient { | ||
|
|
||
| // Time unit: hours | ||
| private static long TTL = 24L; |
Change-Id: I098656e7607ebb326e4708308ccc81d3d81c5b44
Change-Id: I7a9b325a6682939e20fceee7448815fa94512976
houzhizhen
approved these changes
Jun 19, 2020
Linary
requested changes
Jun 19, 2020
| } | ||
|
|
||
| private static Client wrapTrustConfig(String url, ClientConfig config) { | ||
|
|
Change-Id: I2e1e5a7c678cabb3e55a957da45f4640cb80aafc
Linary
approved these changes
Jun 19, 2020
zhoney
approved these changes
Jun 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Ib7153dc7b8d3bf3df9d19662b54cb05ff14c032b
refs:
https://github.com/hugegraph/hugegraph/network/alert/pom.xml/com.google.guava:guava/open
https://github.com/hugegraph/hugegraph/issues/1043