Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nodes and data size to extra param #44

Merged
merged 2 commits into from
Feb 4, 2020
Merged

Add nodes and data size to extra param #44

merged 2 commits into from
Feb 4, 2020

Conversation

Linary
Copy link
Contributor

@Linary Linary commented Jan 14, 2020

No description provided.

@codecov
Copy link

codecov bot commented Jan 14, 2020

Codecov Report

Merging #44 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #44      +/-   ##
===========================================
- Coverage     81.12%   81.1%   -0.02%     
- Complexity      650     653       +3     
===========================================
  Files            56      56              
  Lines          1981    1985       +4     
  Branches        291     291              
===========================================
+ Hits           1607    1610       +3     
  Misses          250     250              
- Partials        124     125       +1
Impacted Files Coverage Δ Complexity Δ
...ava/com/baidu/hugegraph/version/CommonVersion.java 50% <ø> (ø) 1 <0> (ø) ⬇️
...n/java/com/baidu/hugegraph/license/ExtraParam.java 100% <100%> (ø) 14 <4> (+4) ⬆️
.../main/java/com/baidu/hugegraph/perf/Stopwatch.java 85.71% <0%> (-2.05%) 20% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bd64ce...5bff9c7. Read the comment docs.

javeme
javeme previously approved these changes Jan 15, 2020
// The unit is MB
@JsonProperty("data_size")
private long dataSize;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also add vertices and edges as reserved field

@zhoney zhoney merged commit 0a71d12 into master Feb 4, 2020
@zhoney zhoney deleted the add-extra-params branch February 4, 2020 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants