Support keyLock in LockGroup #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
============================================
+ Coverage 76.68% 78.04% +1.35%
- Complexity 556 571 +15
============================================
Files 54 54
Lines 1814 1817 +3
Branches 268 268
============================================
+ Hits 1391 1418 +27
+ Misses 306 281 -25
- Partials 117 118 +1
Continue to review full report at Codecov.
|
javeme
requested changes
Sep 25, 2019
| this.locksMap.putIfAbsent(lockName, new KeyLock()); | ||
| } | ||
| return (KeyLock) this.locksMap.get(lockName); | ||
| } |
Change-Id: I9af3b76a264ddd061195997842e66a47df7c2fe9
javeme
requested changes
Sep 25, 2019
| Lock lock = this.group.lock("lock"); | ||
| Assert.assertTrue(lock instanceof ReentrantLock); | ||
| Lock lock1 = this.group.lock("lock"); | ||
| Assert.assertTrue(lock == lock1); |
Change-Id: I43360da8b4c701bf02d635a7270af96a433ca5c7
javeme
approved these changes
Sep 25, 2019
Linary
approved these changes
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I9af3b76a264ddd061195997842e66a47df7c2fe9