Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let subclass of ConfigOption be able to override parent options #24

Merged
merged 1 commit into from
May 28, 2019

Conversation

javeme
Copy link
Contributor

@javeme javeme commented May 28, 2019

also implement ConfigOption.toString()

Change-Id: I1f1fd5eeaa80252fc093e7cba5af525a32a23c99

also implement ConfigOption.toString()

Change-Id: I1f1fd5eeaa80252fc093e7cba5af525a32a23c99
@codecov
Copy link

codecov bot commented May 28, 2019

Codecov Report

Merging #24 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #24      +/-   ##
============================================
+ Coverage     72.85%   72.94%   +0.08%     
- Complexity      437      439       +2     
============================================
  Files            44       44              
  Lines          1507     1508       +1     
  Branches        228      228              
============================================
+ Hits           1098     1100       +2     
  Misses          302      302              
+ Partials        107      106       -1
Impacted Files Coverage Δ Complexity Δ
.../java/com/baidu/hugegraph/config/ConfigOption.java 74.46% <100%> (+0.55%) 13 <1> (+1) ⬆️
.../java/com/baidu/hugegraph/config/OptionHolder.java 76.92% <100%> (ø) 5 <0> (ø) ⬇️
.../main/java/com/baidu/hugegraph/perf/Stopwatch.java 87.75% <0%> (+2.04%) 21% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ea077f...988b86d. Read the comment docs.

@zhoney zhoney merged commit 0822dd9 into master May 28, 2019
@zhoney zhoney deleted the option-tostring branch May 28, 2019 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants