add PerfUtil.clear()/Bytes.concat()/CollectionUtil.randomSet() #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
============================================
+ Coverage 31.39% 62.3% +30.91%
- Complexity 192 347 +155
============================================
Files 43 43
Lines 1360 1377 +17
Branches 210 213 +3
============================================
+ Hits 427 858 +431
+ Misses 878 420 -458
- Partials 55 99 +44
Continue to review full report at Codecov.
|
javeme
force-pushed
the
perf-util-clear
branch
from
c1bec28 to
36dfb1c
Compare
Linary
requested changes
Feb 28, 2019
| "Can't be cleared when the call has not ended yet"); | ||
| this.stopwatches.clear(); | ||
| } | ||
|
|
||
| public void profilePackage(String... packages) throws | ||
| NotFoundException, CannotCompileException, |
javeme
force-pushed
the
perf-util-clear
branch
7 times, most recently
from
53fac35 to
55d50be
Compare
zhoney
requested changes
Feb 28, 2019
| @@ -68,6 +69,17 @@ | |||
| return true; | |||
| } | |||
|
|
|||
| public static Set<Integer> randomSet(int min, int max, int count) { | |||
| E.checkArgument(max > min, "Invalid min/max: %s/%s", min, max); | |||
| E.checkArgument(count <= max - min, "Incalid count %s", count); | |||
javeme
force-pushed
the
perf-util-clear
branch
2 times, most recently
from
3ebd428 to
f58c22d
Compare
javeme
changed the title
zhoney
requested changes
Mar 1, 2019
| @@ -68,6 +69,17 @@ | |||
| return true; | |||
| } | |||
|
|
|||
| public static Set<Integer> randomSet(int min, int max, int count) { | |||
| E.checkArgument(max > min, "Invalid min/max: %s/%s", min, max); | |||
| E.checkArgument(count <= max - min, "Invalid count %s", count); | |||
also add some unit tests: HugeConfigTest, PerfUtilTest, NumericUtilTest, ReflectionUtilTest and TimeUtilTest. Change-Id: Ida64154a0bdee62e281585836c5e7ccfc6061c06
zhoney
approved these changes
Mar 1, 2019
Linary
approved these changes
Mar 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Ida64154a0bdee62e281585836c5e7ccfc6061c06