feat(common): add a tool method encode #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
imbajin
reviewed
Jul 18, 2024
| import org.junit.Assert; | ||
| import org.junit.Test; | ||
|
|
||
| public class AbstractRestClientTest { |
There was a problem hiding this comment.
we need to register the Class in *Test*Suit like other tests
imbajin
changed the title
imbajin
reviewed
Jul 31, 2024
| return uri.toASCIIString(); | ||
| } catch (URISyntaxException e) { | ||
| throw new IllegalArgumentException("Failed to encode string: " + raw, e); | ||
| return URLEncoder.encode(raw, StandardCharsets.UTF_8.toString()).replace("+", "%20"); |
There was a problem hiding this comment.
Consider a better way to handle the case here
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #146 +/- ##
=========================================
Coverage 93.15% 93.15%
Complexity 65 65
=========================================
Files 9 9
Lines 263 263
Branches 22 22
=========================================
Hits 245 245
Misses 8 8
Partials 10 10 ☔ View full report in Codecov by Sentry. |
imbajin
approved these changes
Aug 20, 2024
VGalaxies
approved these changes
Aug 20, 2024
|
This PR needs to be manually cherry-picked into the server repository afterwards, after apache/incubator-hugegraph#2628 is merged. cc @imbajin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.
Close #145