-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(common): handle spring-boot2/jersey dependency conflicts #131
fix(common): handle spring-boot2/jersey dependency conflicts #131
Conversation
Codecov Report
@@ Coverage Diff @@
## master #131 +/- ##
=========================================
Coverage 93.15% 93.15%
Complexity 65 65
=========================================
Files 9 9
Lines 263 263
Branches 22 22
=========================================
Hits 245 245
Misses 8 8
Partials 10 10
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@@ -89,7 +89,7 @@ | |||
</scm> | |||
|
|||
<properties> | |||
<revision>1.0.0</revision> | |||
<revision>1.0.1</revision> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
search CommonVersion class & also need update it
Line 27 in 82f2a65
public static final Version VERSION = Version.of(CommonVersion.class, "1.0.0"); |
btw, we need a better way to modify the version, at least add a comment in pom for new devs?
@javeme or consider get the version/revision
from pom.xml
rather than class property? (Or remove common version check if not necessary)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it is packaged in a jar, we cannot get the version from the pom.xml, so it fallback to the default version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it is packaged in a jar, we cannot get the version from the pom.xml, so it fallback to the default version.
OK, we could consider these way: (way2 is the easiest)
- check if somewhere possible for us to put the
version
into thejar
file (likemeta
file/info of a jar?) - just leave a comment before
revision
param in pom file (devs could see theNOTE
) - remove the common version check, seems it's not necessary to check it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also need to update RpcVersion.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's keep the status quo until we find a perfect way
@@ -24,5 +24,5 @@ public class RpcVersion { | |||
public static final String NAME = "hugegraph-rpc"; | |||
|
|||
// The second parameter of Version.of() is for all-in-one JAR | |||
public static final Version VERSION = Version.of(RpcVersion.class, "1.0.0"); | |||
public static final Version VERSION = Version.of(RpcVersion.class, "1.0.1"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: we need use one version in one project (currently could keep them..)
|
@@ -89,7 +89,7 @@ | |||
</scm> | |||
|
|||
<properties> | |||
<revision>1.0.0</revision> | |||
<revision>1.0.1</revision> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's keep the status quo until we find a perfect way
test in local, find that the grpc-core maven-metadata.xml file does not contains version 1.28.0, seems so strange! i have ask in grpc community,see 10086 |
…' into feat/commons_dependency_conflict
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix commons dependency conflicts and prevent future uncertainty issues.
also see: 445