Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CollectionUtil.sortByValue() #13

Merged
merged 1 commit into from
Dec 25, 2018
Merged

Add CollectionUtil.sortByValue() #13

merged 1 commit into from
Dec 25, 2018

Conversation

Linary
Copy link
Contributor

@Linary Linary commented Dec 24, 2018

Change-Id: I9152cc7d8fc5a23e3407118ed09c9b6ac116eed9

@codecov
Copy link

codecov bot commented Dec 24, 2018

Codecov Report

Merging #13 into master will increase coverage by 0.9%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master      #13     +/-   ##
===========================================
+ Coverage     24.04%   24.94%   +0.9%     
- Complexity        0      142    +142     
===========================================
  Files            43       43             
  Lines          1277     1291     +14     
  Branches        229      188     -41     
===========================================
+ Hits            307      322     +15     
+ Misses          937      931      -6     
- Partials         33       38      +5
Impacted Files Coverage Δ Complexity Δ
...ava/com/baidu/hugegraph/version/CommonVersion.java 0% <ø> (-50%) 0 <0> (ø)
.../java/com/baidu/hugegraph/util/CollectionUtil.java 81.7% <100%> (+36.39%) 22 <6> (+22) ⬆️
...ain/java/com/baidu/hugegraph/util/VersionUtil.java 37.14% <0%> (-23.43%) 5% <0%> (+5%)
...u/hugegraph/iterator/FlatMapperFilterIterator.java 78.57% <0%> (-7.15%) 5% <0%> (+5%)
...a/com/baidu/hugegraph/iterator/FilterIterator.java 78.57% <0%> (-7.15%) 6% <0%> (+6%)
...a/com/baidu/hugegraph/iterator/MapperIterator.java 86.66% <0%> (-6.67%) 6% <0%> (+6%)
...main/java/com/baidu/hugegraph/testutil/Assert.java 47.05% <0%> (-5.89%) 3% <0%> (+3%)
...m/baidu/hugegraph/iterator/FlatMapperIterator.java 81.48% <0%> (-3.71%) 11% <0%> (+11%)
...m/baidu/hugegraph/iterator/ExtendableIterator.java 80.95% <0%> (-2.39%) 16% <0%> (+16%)
.../main/java/com/baidu/hugegraph/event/EventHub.java 83.09% <0%> (-1.41%) 27% <0%> (+27%)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f20cb8...4892ced. Read the comment docs.

@Linary Linary force-pushed the sort-by-value branch 4 times, most recently from 3853113 to 218dc87 Compare December 24, 2018 13:10
@javeme
Copy link
Contributor

javeme commented Dec 24, 2018

[WARN] Unable to instrument file /home/travis/build/hugegraph/hugegraph-common/target/generated-classes/cobertura/com/baidu/hugegraph/util/CollectionUtil.class
java.lang.IllegalArgumentException: INVOKESPECIAL/STATIC on interfaces require ASM 5
cobertura/cobertura#248
MER-C/wiki-java@c0adbee

@javeme
Copy link
Contributor

javeme commented Dec 24, 2018

[WARN] JavaNCSS got an error while parsing the java file /home/travis/build/hugegraph/hugegraph-common/src/main/java/com/baidu/hugegraph/date/SafeDateFormat.java

ParseException in STDIN

Last useful checkpoint: "com.baidu.hugegraph.date.SafeDateFormatcom.baidu.hugegraph.date.SafeDateFormat.SafeDateFormat(String)"

Encountered " ")" ") "" at line 40, column 51.

@Linary Linary force-pushed the sort-by-value branch 4 times, most recently from 2c0af67 to c7f9f70 Compare December 25, 2018 03:41
Change-Id: I9152cc7d8fc5a23e3407118ed09c9b6ac116eed9
@zhoney zhoney merged commit bbbc8e7 into master Dec 25, 2018
@zhoney zhoney deleted the sort-by-value branch December 25, 2018 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants