-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(apache): support check license header with RAT #108
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,20 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<!-- | ||
Licensed to the Apache Software Foundation (ASF) under one or more | ||
contributor license agreements. See the NOTICE file distributed with | ||
this work for additional information regarding copyright ownership. | ||
The ASF licenses this file to You under the Apache License, Version 2.0 | ||
(the "License"); you may not use this file except in compliance with | ||
the License. You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
--> | ||
<project xmlns="http://maven.apache.org/POM/4.0.0" | ||
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> | ||
|
@@ -18,9 +34,9 @@ | |
</description> | ||
|
||
<parent> | ||
<groupId>org.sonatype.oss</groupId> | ||
<artifactId>oss-parent</artifactId> | ||
<version>7</version> | ||
<groupId>org.apache</groupId> | ||
<artifactId>apache</artifactId> | ||
<version>23</version> | ||
</parent> | ||
|
||
<licenses> | ||
|
@@ -164,6 +180,43 @@ | |
</execution> | ||
</executions> | ||
</plugin> | ||
<!-- Apache RAT for license check --> | ||
<plugin> | ||
<groupId>org.apache.rat</groupId> | ||
<artifactId>apache-rat-plugin</artifactId> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. does it enable auto check in CI? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nope, consider add it in a separate PR (need test it in CI, currently it can't return bool value) PS: use a trick way to show it in CI (enhance it later..) |
||
<configuration> | ||
<excludes> | ||
<exclude>**/*.versionsBackup</exclude> | ||
<exclude>**/*.log</exclude> | ||
<exclude>**/*.txt</exclude> | ||
<exclude>**/*.json</exclude> | ||
<exclude>**/*.conf</exclude> | ||
<exclude>**/*.properties</exclude> | ||
<exclude>dist/**/*</exclude> | ||
<exclude>docs/**/*</exclude> | ||
<exclude>scripts/dev/reviewers</exclude> | ||
<exclude>**/*.md</exclude> | ||
<exclude>**/dependency-reduced-pom.xml</exclude> | ||
<exclude>**/logs/*.log</exclude> | ||
<exclude>**/target/*</exclude> | ||
<exclude>style/*</exclude> | ||
<exclude>ChangeLog</exclude> | ||
<exclude>CONFIG.ini</exclude> | ||
<exclude>GROUPS</exclude> | ||
<exclude>OWNERS</exclude> | ||
<!-- GitHub --> | ||
<exclude>.github/**/*</exclude> | ||
<!-- Intellij --> | ||
<exclude>**/*.iml</exclude> | ||
<exclude>**/*.iws</exclude> | ||
<exclude>**/*.ipr</exclude> | ||
<exclude>**/META-INF/MANIFEST.MF</exclude> | ||
<!-- Maven --> | ||
<exclude>.repository/**</exclude> | ||
</excludes> | ||
<consoleOutput>true</consoleOutput> | ||
</configuration> | ||
</plugin> | ||
</plugins> | ||
</build> | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Separate from this PR? since this pr can be used as a guide for other repos.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this has done in previous PR (merge it this will disappear)