refact: clean code & typo & update the name of getTimeZone #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typo: getTimeZome() -> getTimeZone() And we need check/update the class used it later
Codecov Report
@@ Coverage Diff @@
## master #105 +/- ##
=========================================
Coverage 93.15% 93.15%
Complexity 65 65
=========================================
Files 9 9
Lines 263 263
Branches 22 22
=========================================
Hits 245 245
Misses 8 8
Partials 10 10
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
imbajin
commented
Sep 1, 2022
| return o != null && Arrays.asList(values).containsAll(o); | ||
| } | ||
| }; | ||
| return o -> o != null && new HashSet<>(Arrays.asList(values)).containsAll(o); |
There was a problem hiding this comment.
use hashset to speed up (List.containsAll perf is poor)
javeme
reviewed
Sep 4, 2022
hugegraph-common/src/main/java/com/baidu/hugegraph/rest/RestClient.java
Outdated
Show resolved
Hide resolved
coderzc
approved these changes
Sep 5, 2022
zyxxoo
approved these changes
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typo: getTimeZome() -> getTimeZone()
And we need check/update the class used it later