feat(llm): support basic rag api(v1) #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…n test_api_connection
…ration and the hg-server configuration graphspace problem
… on functionality
imbajin
reviewed
Aug 15, 2024
vichayturen
reviewed
Aug 16, 2024
vichayturen
reviewed
Aug 16, 2024
vichayturen
approved these changes
Aug 16, 2024
…r issues and encapsulate the http api in a single package
dosubot
bot
added
size:L
imbajin
reviewed
Aug 17, 2024
Comment on lines
57
to
59
| def rag_http_api(app: FastAPI, graph_rag_func, apply_graph_configuration_func, | ||
| apply_llm_configuration_func, apply_embedding_configuration_func): | ||
| @app.post("/rag") | ||
| def graph_rag_api(req: RAGRequest): |
There was a problem hiding this comment.
Is it the proper/right way to use the fastapi?
- method -> http_method?
- class -> http_method?
- directly http_method?
imbajin
reviewed
Aug 17, 2024
| @@ -141,13 +134,110 @@ def build_kg(file, schema, example_prompt, build_mode): # pylint: disable=too-m | |||
| raise gr.Error(str(e)) | |||
There was a problem hiding this comment.
fixme: return 'str', but context got 'dict[str, Any]'... (unify it)
imbajin
changed the title
vichayturen
reviewed
Aug 18, 2024
| raise gr.Error("PDF will be supported later! Try to upload text/docx now") | ||
| else: | ||
| raise gr.Error("Please input txt or docx file.") | ||
| builder = KgBuilder(LLMs().get_llm(), Embeddings().get_embedding(), get_hg_client()) | ||
|
|
||
| if build_mode != "Rebuild vertex index": | ||
| if build_mode != BuildMode.REBUILD_VERTEX_INDEX: |
There was a problem hiding this comment.
Maybe this should be build_mode != BuildMode.REBUILD_VERTEX_INDEX.value?
vichayturen
added a commit
to vichayturen/incubator-hugegraph-ai
that referenced
this pull request
Aug 18, 2024
dosubot
bot
added
size:XL
imbajin
approved these changes
Aug 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There may be 2 ways to integrate fastapi into the gradio app:
refer: