Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(llm): timely execute vid embedding & enhance some HTTP logic #141

Merged
merged 21 commits into from
Dec 24, 2024

Conversation

MrJs133
Copy link
Contributor

@MrJs133 MrJs133 commented Dec 22, 2024

  1. change the location of the button Rebuild vid Index
  2. After clicking the button Load into GraphDB(2), executeimport_graph_data and fit_vid_index in sequence
  3. excute fit_vid_index once an hour
  4. fix a string of http request wrong usage with timeout & retry params

Verified

This commit was signed with the committer’s verified signature.
casperdcl Casper da Costa-Luis
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 22, 2024
@github-actions github-actions bot added the llm label Dec 22, 2024
@MrJs133 MrJs133 changed the title feat(llm): Automatically excute rebuild_vid after clicking button load_into_graphDB && excuterebuild_vid periodically feat(llm): Automatically excute rebuild_vid after clicking button load_into_graphDB && excute rebuild_vid periodically Dec 22, 2024
@dosubot dosubot bot added the enhancement New feature or request label Dec 22, 2024
imbajin
imbajin previously approved these changes Dec 24, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 24, 2024
Comment on lines 64 to 69
try:
await asyncio.to_thread(fit_vid_index)
log.info("fit_vid_index function executed successfully.")
except Exception as e:
log.error("Error executing fit_vid_index: %s", e, exc_info=True)
raise Exception("Error executing fit_vid_index") from e
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate try-except logic?

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Dec 24, 2024
@imbajin imbajin merged commit f1713b0 into apache:main Dec 24, 2024
11 checks passed
@imbajin imbajin changed the title feat(llm): Automatically excute rebuild_vid after clicking button load_into_graphDB && excute rebuild_vid periodically feat(llm): timely execute vid embedding & enhance some HTTP logic Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer llm python-client size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants