This repository has been archived by the owner on Feb 6, 2024. It is now read-only.
feat: support shard affinity #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShiKaiWi
force-pushed
the
feat-support-shard-affinity
branch
from
f25bf8e
to
6ca9a67
Compare
ShiKaiWi
force-pushed
the
feat-support-shard-affinity
branch
from
6ca9a67
to
24458bc
Compare
ZuLiangWang
reviewed
Oct 8, 2023
server/coordinator/scheduler/nodepicker/hash/consistent_uniform.go
Outdated
Show resolved
Hide resolved
server/coordinator/scheduler/nodepicker/hash/consistent_uniform.go
Outdated
Show resolved
Hide resolved
ShiKaiWi
force-pushed
the
feat-support-shard-affinity
branch
from
8d63313
to
7a3fe18
Compare
ZuLiangWang
reviewed
Oct 8, 2023
server/coordinator/scheduler/nodepicker/hash/consistent_uniform.go
Outdated
Show resolved
Hide resolved
ShiKaiWi
force-pushed
the
feat-support-shard-affinity
branch
from
a13aba8
to
e902ca5
Compare
ShiKaiWi
force-pushed
the
feat-support-shard-affinity
branch
from
e902ca5
to
de61294
Compare
ZuLiangWang
reviewed
Oct 9, 2023
server/coordinator/scheduler/nodepicker/hash/consistent_uniform.go
Outdated
Show resolved
Hide resolved
ZuLiangWang
reviewed
Oct 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
In some cases, some specific shards may contain tables whose query or write requests are massive, and these tables are hoped to be migrated to some node alone.
Detailed Changes
Test Plan
New unit tests are added.