Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

chore: remove coverage #234

Merged
merged 1 commit into from
Sep 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 3 additions & 27 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,31 +1,7 @@
# Which issue does this PR close?
## Rationale

Closes #

# Rationale for this change

<!---
Why are you proposing this change? If this is already explained clearly in the issue, then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
## Detailed Changes

# What changes are included in this PR?

<!---
There is no need to duplicate the description in the issue here, but it is sometimes worth providing a summary of the individual changes in this PR to help reviewers understand the structure.
-->

# Are there any user-facing changes?

<!---
Please mention if:

- there are user-facing changes that need to update the documentation or configuration.
- this is a breaking change to public APIs
-->

# How does this change test

<!--
Please describe how you test this change (like by unit test case, integration test or some other ways) if this change has touched the code.
-->
## Test Plan
5 changes: 3 additions & 2 deletions .github/workflows/check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,9 @@ jobs:
- run: |
make install-tools
make test
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v3
# TODO: disable for now, reopen this later
# - name: Upload coverage to Codecov
# uses: codecov/codecov-action@v3
integration-test:
runs-on: ubuntu-latest
timeout-minutes: 60
Expand Down
8 changes: 4 additions & 4 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ install-tools:
@grep '_' tools.go | sed 's/"//g' | awk '{print $$2}' | xargs go install

META_PKG := github.com/CeresDB/ceresmeta
PACKAGES := $(shell go list ./... | tail -n +2)
PACKAGES := $(shell go list ./... | tail -n +2)
PACKAGE_DIRECTORIES := $(subst $(META_PKG)/,,$(PACKAGES))

check: install-tools
check:
@ echo "check license ..."
@ make check-license
@ echo "gofmt ..."
Expand All @@ -29,14 +29,14 @@ check: install-tools
@ echo "revive ..."
@ revive -formatter friendly -config revive.toml $(PACKAGES)

test: install-tools
test:
@ echo "go test ..."
@ go test -timeout 5m -coverprofile=coverage.txt -covermode=atomic $(PACKAGES)

check-license:
@ sh ./scripts/check-license.sh

build: check
build:
@ go build -ldflags="-X main.commitID=$(COMMIT_ID) -X main.branchName=$(BRANCH_NAME) -X main.buildDate=$(BUILD_DATE)" -o ceresmeta ./cmd/meta/...

integration_test: build
Expand Down