This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Improving Kubernetes scheduler logic #3653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heron/schedulers/src/java/org/apache/heron/scheduler/kubernetes/V1Controller.java
Show resolved
Hide resolved
|
I updated the logic to use a try-with-resource. I was noticing warnings about unclosed connections when it was throwing the ApiException. Hopefully this change will also help with that. |
joshfischer1108
approved these changes
Jan 3, 2021
|
Are there no unit tests that cover this code? |
|
@nicknezis are these changes covered by unit tests or integration tests? |
|
The Kubernetes scheduler doesn't seem to have many unit tests. Do the other schedulers? Might be worth adding an issue to create some? |
|
I think creating issues would be a good start. I can add some as well if you let me know which ones I should write them for. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3652 . This Pull Request adds extra logic to handle Kubernetes delete requests for Topology StatefulSet and Service that do not exist in Kubernetes. This code should now gracefully handle the
HTTP_NOT_FOUNDresponse code.