Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Added ability to disable base_url in Helm chart #3619

Merged
merged 2 commits into from
Sep 23, 2020
Merged

Added ability to disable base_url in Helm chart #3619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4ba8f7
Added ability to disable base_url
nicknezis Sep 17, 2020
eab338b
Updated to remove the need for a seperate variable
nicknezis Sep 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion deploy/kubernetes/helm/templates/tools.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,9 @@ spec:
- >-
heron-ui
--port=8889
--base_url={{ .Values.heron.url | default $defaultUrl }}
{{- if not (kindIs "invalid" .Values.heron.url) }}
--base_url={{ eq .Values.heron.url "-" | ternary $defaultUrl .Values.heron.url }}
{{- end }}
- name: heron-apiserver
image: {{ .Values.image }}
imagePullPolicy: {{ .Values.imagePullPolicy }}
Expand Down
4 changes: 3 additions & 1 deletion deploy/kubernetes/helm/values.yaml.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,9 @@ jobReplicas: 1
# amount of memory to provide for API server
apiServerMemory: 512M
heron:
url: ~
# set to `-` to set base_url to the default k8s proxy URL
# set to `null` to remove the use of base_url
url: "-"
# Topologies uploader
uploader:
class: dlog # s3
Expand Down