Use click instead of argparse in py instance #3598

Code0x58 · 2020-08-04T21:23:28Z

No description provided.

huijunwu · 2020-08-06T23:13:37Z

Tested on Ubuntu20.04

The job can run. The heron-instance logs look good to me.

Found some warning in heron-executor log:

RuntimeWarning: 'heron.instance.src.python.instance.st_heron_instance' found in sys.modules after import of package 'heron.instance.src.python.instance', but prior to execution of 'heron.instance.src.python.instance.st_heron_instance'; this may result in unpredictable behaviour

[2020-08-06 23:01:57 +0000] [INFO]: Set up process group; executor becomes leader
[2020-08-06 23:01:57 +0000] [INFO]: Register the SIGTERM signal handler
[2020-08-06 23:01:57 +0000] [INFO]: Register the atexit clean up
[2020-08-06 23:01:57 +0000] [INFO]: Start state manager watches
[2020-08-06 23:01:57 +0000] [INFO]: Connecting to file state with rootpath: /home/ubuntu/.herondata/repository/state/local
[2020-08-06 23:01:57 +0000] [INFO]: Registered state watch for packing plan changes with state manager <heron.statemgrs.src.python.filestatemanager.FileStateManager object at 0x7fe03de4d9d0>.
[2020-08-06 23:01:57 +0000] [INFO]: Start process monitor
[2020-08-06 23:02:02 +0000] [INFO]: PackingPlan change detected on shard 1, relaunching effected processes.
[2020-08-06 23:02:02 +0000] [INFO]: Updating executor processes
[2020-08-06 23:02:03 +0000] [INFO]: Detected JVM version 11.0.8
[2020-08-06 23:02:03 +0000] [INFO]: Python instance container_1_exclaim2_1 component: exclaim2
[2020-08-06 23:02:03 +0000] [INFO]: Python instance container_1_exclaim2_2 component: exclaim2
[2020-08-06 23:02:03 +0000] [INFO]: Python instance container_1_exclaim1_3 component: exclaim1
[2020-08-06 23:02:03 +0000] [INFO]: Python instance container_1_exclaim1_4 component: exclaim1
[2020-08-06 23:02:03 +0000] [INFO]: Python instance container_1_word_5 component: word
[2020-08-06 23:02:03 +0000] [INFO]: Python instance container_1_word_6 component: word
[2020-08-06 23:02:03 +0000] [INFO]: current commands: []
[2020-08-06 23:02:03 +0000] [INFO]: new commands    : ['container_1_exclaim1_3', 'container_1_exclaim1_4', 'container_1_exclaim2_1', 'container_1_exclaim2_2', 'container_1_word_5', 'container_1_word_6', 'heron-shell-1', 'metricsmgr-1', 'stmgr-1']
[2020-08-06 23:02:03 +0000] [INFO]: commands_to_kill: []
[2020-08-06 23:02:03 +0000] [INFO]: commands_to_keep: []
[2020-08-06 23:02:03 +0000] [INFO]: commands_to_start: ['container_1_exclaim1_3', 'container_1_exclaim1_4', 'container_1_exclaim2_1', 'container_1_exclaim2_2', 'container_1_word_5', 'container_1_word_6', 'heron-shell-1', 'metricsmgr-1', 'stmgr-1']
[2020-08-06 23:02:03 +0000] [INFO]: Start processes
[2020-08-06 23:02:03 +0000] [INFO]: Running stmgr-1 process as ./heron-core/bin/heron-stmgr --topology_name=my-python-topology --topology_id=my-python-topology10b6c1e7-0390-45ca-9e93-d874109e48a5 --topologydefn_file=my-python-topology.defn --zkhostportlist=LOCALMODE --zkroot=/home/ubuntu/.herondata/repository/state/local --stmgr_id=stmgr-1 --instance_ids=container_1_exclaim2_1,container_1_exclaim2_2,container_1_exclaim1_3,container_1_exclaim1_4,container_1_word_5,container_1_word_6 --myhost=vm --data_port=33133 --local_data_port=33261 --metricsmgr_port=46095 --shell_port=41917 --config_file=./heron-conf/heron_internals.yaml --override_config_file=./heron-conf/override.yaml --ckptmgr_port=33145 --ckptmgr_id=ckptmgr-1 --metricscachemgr_mode=cluster
[2020-08-06 23:02:03 +0000] [INFO]: Logging pid 52602 to file stmgr-1.pid
[2020-08-06 23:02:03 +0000] [INFO]: stmgr-1 stdout: WARNING: Logging before InitGoogleLogging() is written to STDERR
[2020-08-06 23:02:03 +0000] [INFO]: stmgr-1 stdout: I0806 23:02:03.250452 52602 yaml-file-reader.cpp:58] Config file ./heron-conf/heron_internals.yaml changed. reloading..
[2020-08-06 23:02:03 +0000] [INFO]: Running metricsmgr-1 process as /usr/lib/jvm/java-11-openjdk-amd64/bin/java -Xmx1024M -XX:+PrintCommandLineFlags -Djava.net.preferIPv4Stack=true -verbosegc -XX:+UseG1GC -XX:+ParallelRefProcEnabled -XX:+UseStringDeduplication -XX:MaxGCPauseMillis=100 -XX:InitiatingHeapOccupancyPercent=30 -XX:+HeapDumpOnOutOfMemoryError -XX:ParallelGCThreads=4 -Xlog:gc*,safepoint=info:file=log-files/gc.metricsmgr-1.log:tags,time,uptime,level:filecount=5,filesize=100M -cp ./heron-core/lib/metricsmgr/* org.apache.heron.metricsmgr.MetricsManager --id=metricsmgr-1 --port=46095 --topology=my-python-topology --cluster=local --role=ubuntu --environment=default --topology-id=my-python-topology10b6c1e7-0390-45ca-9e93-d874109e48a5 --system-config-file=./heron-conf/heron_internals.yaml --override-config-file=./heron-conf/override.yaml --sink-config-file=./heron-conf/metrics_sinks.yaml
[2020-08-06 23:02:03 +0000] [INFO]: Logging pid 52604 to file metricsmgr-1.pid
[2020-08-06 23:02:03 +0000] [INFO]: metricsmgr-1 stdout: -XX:G1ConcRefinementThreads=4 -XX:GCDrainStackTargetSize=64 -XX:+HeapDumpOnOutOfMemoryError -XX:InitialHeapSize=256721792 -XX:InitiatingHeapOccupancyPercent=30 -XX:MaxGCPauseMillis=100 -XX:MaxHeapSize=1073741824 -XX:ParallelGCThreads=4 -XX:+ParallelRefProcEnabled -XX:+PrintCommandLineFlags -XX:ReservedCodeCacheSize=251658240 -XX:+SegmentedCodeCache -XX:+UseCompressedClassPointers -XX:+UseCompressedOops -XX:+UseG1GC -XX:+UseStringDeduplication 
[2020-08-06 23:02:03 +0000] [INFO]: Running container_1_exclaim2_1 process as ./heron-core/bin/heron-python-instance --topology_name=my-python-topology --topology_id=my-python-topology10b6c1e7-0390-45ca-9e93-d874109e48a5 --instance_id=container_1_exclaim2_1 --component_name=exclaim2 --task_id=1 --component_index=0 --stmgr_id=stmgr-1 --stmgr_port=33261 --metricsmgr_port=46095 --sys_config=./heron-conf/heron_internals.yaml --override_config=./heron-conf/override.yaml --topology_pex=exclamation-topology.pex --max_ram=1073741824
[2020-08-06 23:02:03 +0000] [INFO]: Logging pid 52607 to file container_1_exclaim2_1.pid
[2020-08-06 23:02:03 +0000] [INFO]: Running container_1_exclaim2_2 process as ./heron-core/bin/heron-python-instance --topology_name=my-python-topology --topology_id=my-python-topology10b6c1e7-0390-45ca-9e93-d874109e48a5 --instance_id=container_1_exclaim2_2 --component_name=exclaim2 --task_id=2 --component_index=1 --stmgr_id=stmgr-1 --stmgr_port=33261 --metricsmgr_port=46095 --sys_config=./heron-conf/heron_internals.yaml --override_config=./heron-conf/override.yaml --topology_pex=exclamation-topology.pex --max_ram=1073741824
[2020-08-06 23:02:03 +0000] [INFO]: metricsmgr-1 stdout: [0.064s][info][gc] Using G1
[2020-08-06 23:02:03 +0000] [INFO]: Logging pid 52615 to file container_1_exclaim2_2.pid
[2020-08-06 23:02:03 +0000] [INFO]: Running container_1_exclaim1_3 process as ./heron-core/bin/heron-python-instance --topology_name=my-python-topology --topology_id=my-python-topology10b6c1e7-0390-45ca-9e93-d874109e48a5 --instance_id=container_1_exclaim1_3 --component_name=exclaim1 --task_id=3 --component_index=0 --stmgr_id=stmgr-1 --stmgr_port=33261 --metricsmgr_port=46095 --sys_config=./heron-conf/heron_internals.yaml --override_config=./heron-conf/override.yaml --topology_pex=exclamation-topology.pex --max_ram=1073741824
[2020-08-06 23:02:03 +0000] [INFO]: Logging pid 52618 to file container_1_exclaim1_3.pid
[2020-08-06 23:02:03 +0000] [INFO]: Running container_1_exclaim1_4 process as ./heron-core/bin/heron-python-instance --topology_name=my-python-topology --topology_id=my-python-topology10b6c1e7-0390-45ca-9e93-d874109e48a5 --instance_id=container_1_exclaim1_4 --component_name=exclaim1 --task_id=4 --component_index=1 --stmgr_id=stmgr-1 --stmgr_port=33261 --metricsmgr_port=46095 --sys_config=./heron-conf/heron_internals.yaml --override_config=./heron-conf/override.yaml --topology_pex=exclamation-topology.pex --max_ram=1073741824
[2020-08-06 23:02:03 +0000] [INFO]: Logging pid 52625 to file container_1_exclaim1_4.pid
[2020-08-06 23:02:03 +0000] [INFO]: Running container_1_word_5 process as ./heron-core/bin/heron-python-instance --topology_name=my-python-topology --topology_id=my-python-topology10b6c1e7-0390-45ca-9e93-d874109e48a5 --instance_id=container_1_word_5 --component_name=word --task_id=5 --component_index=0 --stmgr_id=stmgr-1 --stmgr_port=33261 --metricsmgr_port=46095 --sys_config=./heron-conf/heron_internals.yaml --override_config=./heron-conf/override.yaml --topology_pex=exclamation-topology.pex --max_ram=1073741824
[2020-08-06 23:02:03 +0000] [INFO]: Logging pid 52628 to file container_1_word_5.pid
[2020-08-06 23:02:03 +0000] [INFO]: Running container_1_word_6 process as ./heron-core/bin/heron-python-instance --topology_name=my-python-topology --topology_id=my-python-topology10b6c1e7-0390-45ca-9e93-d874109e48a5 --instance_id=container_1_word_6 --component_name=word --task_id=6 --component_index=1 --stmgr_id=stmgr-1 --stmgr_port=33261 --metricsmgr_port=46095 --sys_config=./heron-conf/heron_internals.yaml --override_config=./heron-conf/override.yaml --topology_pex=exclamation-topology.pex --max_ram=1073741824
[2020-08-06 23:02:03 +0000] [INFO]: Logging pid 52630 to file container_1_word_6.pid
[2020-08-06 23:02:03 +0000] [INFO]: Running heron-shell-1 process as ./heron-core/bin/heron-shell --port=41917 --log_file_prefix=log-files/heron-shell-1.log --secret=my-python-topology10b6c1e7-0390-45ca-9e93-d874109e48a5
[2020-08-06 23:02:03 +0000] [INFO]: Logging pid 52633 to file heron-shell-1.pid
[2020-08-06 23:02:03 +0000] [INFO]: Launch complete - processes killed=0 kept=0 started=9 monitored=9
[2020-08-06 23:02:08 +0000] [INFO]: metricsmgr-1 stdout: [4.951s][info][gc] GC(0) Pause Young (Normal) (G1 Evacuation Pause) 12M->2M(248M) 68.479ms
[2020-08-06 23:02:10 +0000] [INFO]: metricsmgr-1 stdout: [7.017s][info][gc] GC(1) Pause Young (Normal) (G1 Evacuation Pause) 12M->3M(248M) 30.654ms
[2020-08-06 23:02:15 +0000] [INFO]: container_1_word_5 stdout: /usr/lib/python3.8/runpy.py:126: RuntimeWarning: 'heron.instance.src.python.instance.st_heron_instance' found in sys.modules after import of package 'heron.instance.src.python.instance', but prior to execution of 'heron.instance.src.python.instance.st_heron_instance'; this may result in unpredictable behaviour
[2020-08-06 23:02:15 +0000] [INFO]: container_1_word_5 stdout:   warn(RuntimeWarning(msg))
[2020-08-06 23:02:15 +0000] [INFO]: container_1_word_6 stdout: /usr/lib/python3.8/runpy.py:126: RuntimeWarning: 'heron.instance.src.python.instance.st_heron_instance' found in sys.modules after import of package 'heron.instance.src.python.instance', but prior to execution of 'heron.instance.src.python.instance.st_heron_instance'; this may result in unpredictable behaviour
[2020-08-06 23:02:15 +0000] [INFO]: container_1_word_6 stdout:   warn(RuntimeWarning(msg))
[2020-08-06 23:02:15 +0000] [INFO]: container_1_word_5 stdout: 
[2020-08-06 23:02:15 +0000] [INFO]: container_1_word_5 (pid=52628) exited with status 0. command=./heron-core/bin/heron-python-instance --topology_name=my-python-topology --topology_id=my-python-topology10b6c1e7-0390-45ca-9e93-d874109e48a5 --instance_id=container_1_word_5 --component_name=word --task_id=5 --component_index=0 --stmgr_id=stmgr-1 --stmgr_port=33261 --metricsmgr_port=46095 --sys_config=./heron-conf/heron_internals.yaml --override_config=./heron-conf/override.yaml --topology_pex=exclamation-topology.pex --max_ram=1073741824
[2020-08-06 23:02:15 +0000] [INFO]: container_1_word_5 stdout: 
[2020-08-06 23:02:15 +0000] [INFO]: container_1_word_6 stdout: 
[2020-08-06 23:02:25 +0000] [INFO]: Running container_1_word_5 process as ./heron-core/bin/heron-python-instance --topology_name=my-python-topology --topology_id=my-python-topology10b6c1e7-0390-45ca-9e93-d874109e48a5 --instance_id=container_1_word_5 --component_name=word --task_id=5 --component_index=0 --stmgr_id=stmgr-1 --stmgr_port=33261 --metricsmgr_port=46095 --sys_config=./heron-conf/heron_internals.yaml --override_config=./heron-conf/override.yaml --topology_pex=exclamation-topology.pex --max_ram=1073741824
[2020-08-06 23:02:25 +0000] [INFO]: Logging pid 52787 to file container_1_word_5.pid
[2020-08-06 23:02:25 +0000] [INFO]: container_1_word_6 (pid=52630) exited with status 0. command=./heron-core/bin/heron-python-instance --topology_name=my-python-topology --topology_id=my-python-topology10b6c1e7-0390-45ca-9e93-d874109e48a5 --instance_id=container_1_word_6 --component_name=word --task_id=6 --component_index=1 --stmgr_id=stmgr-1 --stmgr_port=33261 --metricsmgr_port=46095 --sys_config=./heron-conf/heron_internals.yaml --override_config=./heron-conf/override.yaml --topology_pex=exclamation-topology.pex --max_ram=1073741824
[2020-08-06 23:02:25 +0000] [INFO]: container_1_word_6 stdout: 
[2020-08-06 23:02:31 +0000] [INFO]: container_1_word_5 stdout: /usr/lib/python3.8/runpy.py:126: RuntimeWarning: 'heron.instance.src.python.instance.st_heron_instance' found in sys.modules after import of package 'heron.instance.src.python.instance', but prior to execution of 'heron.instance.src.python.instance.st_heron_instance'; this may result in unpredictable behaviour
[2020-08-06 23:02:31 +0000] [INFO]: container_1_word_5 stdout:   warn(RuntimeWarning(msg))
[2020-08-06 23:02:32 +0000] [INFO]: container_1_word_5 stdout: 
[2020-08-06 23:02:35 +0000] [INFO]: Running container_1_word_6 process as ./heron-core/bin/heron-python-instance --topology_name=my-python-topology --topology_id=my-python-topology10b6c1e7-0390-45ca-9e93-d874109e48a5 --instance_id=container_1_word_6 --component_name=word --task_id=6 --component_index=1 --stmgr_id=stmgr-1 --stmgr_port=33261 --metricsmgr_port=46095 --sys_config=./heron-conf/heron_internals.yaml --override_config=./heron-conf/override.yaml --topology_pex=exclamation-topology.pex --max_ram=1073741824
[2020-08-06 23:02:35 +0000] [INFO]: Logging pid 52797 to file container_1_word_6.pid
[2020-08-06 23:02:35 +0000] [INFO]: container_1_word_5 (pid=52787) exited with status 0. command=./heron-core/bin/heron-python-instance --topology_name=my-python-topology --topology_id=my-python-topology10b6c1e7-0390-45ca-9e93-d874109e48a5 --instance_id=container_1_word_5 --component_name=word --task_id=5 --component_index=0 --stmgr_id=stmgr-1 --stmgr_port=33261 --metricsmgr_port=46095 --sys_config=./heron-conf/heron_internals.yaml --override_config=./heron-conf/override.yaml --topology_pex=exclamation-topology.pex --max_ram=1073741824
[2020-08-06 23:02:35 +0000] [INFO]: container_1_word_5 stdout: 
[2020-08-06 23:02:41 +0000] [INFO]: container_1_word_6 stdout: /usr/lib/python3.8/runpy.py:126: RuntimeWarning: 'heron.instance.src.python.instance.st_heron_instance' found in sys.modules after import of package 'heron.instance.src.python.instance', but prior to execution of 'heron.instance.src.python.instance.st_heron_instance'; this may result in unpredictable behaviour
[2020-08-06 23:02:41 +0000] [INFO]: container_1_word_6 stdout:   warn(RuntimeWarning(msg))
[2020-08-06 23:02:42 +0000] [INFO]: container_1_word_6 stdout: 
[2020-08-06 23:02:45 +0000] [INFO]: Running container_1_word_5 process as ./heron-core/bin/heron-python-instance --topology_name=my-python-topology --topology_id=my-python-topology10b6c1e7-0390-45ca-9e93-d874109e48a5 --instance_id=container_1_word_5 --component_name=word --task_id=5 --component_index=0 --stmgr_id=stmgr-1 --stmgr_port=33261 --metricsmgr_port=46095 --sys_config=./heron-conf/heron_internals.yaml --override_config=./heron-conf/override.yaml --topology_pex=exclamation-topology.pex --max_ram=1073741824
[2020-08-06 23:02:45 +0000] [INFO]: Logging pid 52810 to file container_1_word_5.pid
[2020-08-06 23:02:45 +0000] [INFO]: container_1_word_6 (pid=52797) exited with status 0. command=./heron-core/bin/heron-python-instance --topology_name=my-python-topology --topology_id=my-python-topology10b6c1e7-0390-45ca-9e93-d874109e48a5 --instance_id=container_1_word_6 --component_name=word --task_id=6 --component_index=1 --stmgr_id=stmgr-1 --stmgr_port=33261 --metricsmgr_port=46095 --sys_config=./heron-conf/heron_internals.yaml --override_config=./heron-conf/override.yaml --topology_pex=exclamation-topology.pex --max_ram=1073741824
[2020-08-06 23:02:45 +0000] [INFO]: container_1_word_6 stdout: 
[2020-08-06 23:02:55 +0000] [INFO]: Running container_1_word_6 process as ./heron-core/bin/heron-python-instance --topology_name=my-python-topology --topology_id=my-python-topology10b6c1e7-0390-45ca-9e93-d874109e48a5 --instance_id=container_1_word_6 --component_name=word --task_id=6 --component_index=1 --stmgr_id=stmgr-1 --stmgr_port=33261 --metricsmgr_port=46095 --sys_config=./heron-conf/heron_internals.yaml --override_config=./heron-conf/override.yaml --topology_pex=exclamation-topology.pex --max_ram=1073741824
[2020-08-06 23:02:55 +0000] [INFO]: Logging pid 52813 to file container_1_word_6.pid
[2020-08-06 23:03:02 +0000] [INFO]: container_1_word_6 stdout: /usr/lib/python3.8/runpy.py:126: RuntimeWarning: 'heron.instance.src.python.instance.st_heron_instance' found in sys.modules after import of package 'heron.instance.src.python.instance', but prior to execution of 'heron.instance.src.python.instance.st_heron_instance'; this may result in unpredictable behaviour
[2020-08-06 23:03:02 +0000] [INFO]: container_1_word_6 stdout:   warn(RuntimeWarning(msg))
[2020-08-06 23:03:02 +0000] [INFO]: container_1_word_6 stdout: 
[2020-08-06 23:03:02 +0000] [INFO]: container_1_word_6 (pid=52813) exited with status 0. command=./heron-core/bin/heron-python-instance --topology_name=my-python-topology --topology_id=my-python-topology10b6c1e7-0390-45ca-9e93-d874109e48a5 --instance_id=container_1_word_6 --component_name=word --task_id=6 --component_index=1 --stmgr_id=stmgr-1 --stmgr_port=33261 --metricsmgr_port=46095 --sys_config=./heron-conf/heron_internals.yaml --override_config=./heron-conf/override.yaml --topology_pex=exclamation-topology.pex --max_ram=1073741824
[2020-08-06 23:03:02 +0000] [INFO]: container_1_word_6 stdout: 
[2020-08-06 23:03:12 +0000] [INFO]: Running container_1_word_6 process as ./heron-core/bin/heron-python-instance --topology_name=my-python-topology --topology_id=my-python-topology10b6c1e7-0390-45ca-9e93-d874109e48a5 --instance_id=container_1_word_6 --component_name=word --task_id=6 --component_index=1 --stmgr_id=stmgr-1 --stmgr_port=33261 --metricsmgr_port=46095 --sys_config=./heron-conf/heron_internals.yaml --override_config=./heron-conf/override.yaml --topology_pex=exclamation-topology.pex --max_ram=1073741824
[2020-08-06 23:03:12 +0000] [INFO]: Logging pid 52817 to file container_1_word_6.pid
[2020-08-06 23:03:18 +0000] [INFO]: container_1_word_6 stdout: /usr/lib/python3.8/runpy.py:126: RuntimeWarning: 'heron.instance.src.python.instance.st_heron_instance' found in sys.modules after import of package 'heron.instance.src.python.instance', but prior to execution of 'heron.instance.src.python.instance.st_heron_instance'; this may result in unpredictable behaviour
[2020-08-06 23:03:18 +0000] [INFO]: container_1_word_6 stdout:   warn(RuntimeWarning(msg))
[2020-08-06 23:03:18 +0000] [INFO]: container_1_word_6 stdout: 
[2020-08-06 23:03:18 +0000] [INFO]: container_1_word_6 (pid=52817) exited with status 0. command=./heron-core/bin/heron-python-instance --topology_name=my-python-topology --topology_id=my-python-topology10b6c1e7-0390-45ca-9e93-d874109e48a5 --instance_id=container_1_word_6 --component_name=word --task_id=6 --component_index=1 --stmgr_id=stmgr-1 --stmgr_port=33261 --metricsmgr_port=46095 --sys_config=./heron-conf/heron_internals.yaml --override_config=./heron-conf/override.yaml --topology_pex=exclamation-topology.pex --max_ram=1073741824
[2020-08-06 23:03:18 +0000] [INFO]: container_1_word_6 stdout: 
[2020-08-06 23:03:28 +0000] [INFO]: Running container_1_word_6 process as ./heron-core/bin/heron-python-instance --topology_name=my-python-topology --topology_id=my-python-topology10b6c1e7-0390-45ca-9e93-d874109e48a5 --instance_id=container_1_word_6 --component_name=word --task_id=6 --component_index=1 --stmgr_id=stmgr-1 --stmgr_port=33261 --metricsmgr_port=46095 --sys_config=./heron-conf/heron_internals.yaml --override_config=./heron-conf/override.yaml --topology_pex=exclamation-topology.pex --max_ram=1073741824
[2020-08-06 23:03:28 +0000] [INFO]: Logging pid 52821 to file container_1_word_6.pid
[2020-08-06 23:03:57 +0000] [INFO]: signal_handler invoked with signal 15
[2020-08-06 23:03:57 +0000] [INFO]: Stopping state managers
[2020-08-06 23:03:57 +0000] [INFO]: Executor terminated; exiting all process in executor.
[2020-08-06 23:03:57 +0000] [INFO]: container_1_word_6 stdout: 
[2020-08-06 23:03:57 +0000] [INFO]: stmgr-1 stdout: 
[2020-08-06 23:03:57 +0000] [INFO]: heron-shell-1 stdout: 
[2020-08-06 23:03:57 +0000] [INFO]: container_1_exclaim1_3 stdout: 
[2020-08-06 23:03:57 +0000] [INFO]: container_1_exclaim2_2 stdout: 
[2020-08-06 23:03:57 +0000] [INFO]: container_1_exclaim2_1 stdout: 
[2020-08-06 23:03:57 +0000] [INFO]: container_1_exclaim1_4 stdout: 
[2020-08-06 23:03:57 +0000] [INFO]: container_1_word_5 stdout: 
[2020-08-06 23:03:57 +0000] [INFO]: metricsmgr-1 stdout: 
[2020-08-06 23:04:02 +0000] [INFO]: signal_handler invoked with signal 15
[2020-08-06 23:04:02 +0000] [INFO]: Stopping state managers

This is a clean up which also avoids [this kind of runtime warning](https://stackoverflow.com/questions/43393764/python-3-6-project-structure-leads-to-runtimewarning).

Code0x58 · 2020-08-21T20:36:26Z

Thanks @huijunwu! I just pushed a change to avoid triggering that existing issue, which hopefully wasn't causing anything or relied on.

An example of what causes that RuntimeWarning:

$ tree
.
└── a
    ├── b.py
    └── __init__.py
$ cat a/__init__.py
print("import a")
from . import b
$ cat a/b.py
print("import b")
if __name__ == "__main__":
    print("run b")
$ python -m a.b
import a
import b
/usr/lib/python3.8/runpy.py:126: RuntimeWarning: 'a.b' found in sys.modules after import of package 'a', but prior to execution of 'a.b'; this may result in unpredictable behaviour
  warn(RuntimeWarning(msg))
import b
run b

joshfischer1108 · 2020-10-30T03:46:35Z

@Code0x58 is this ready to be re-reviewed?

Code0x58 · 2020-10-30T10:26:41Z

Yep. I think it's fair to assume that @huijunwu's check still holds, then the change on top to stop the logs warning should be ok (test suite still passes, although it could have in theory caused issues), so could call it good for merge as is

Code0x58 force-pushed the click-py-instance branch from 9636663 to bcb20fc Compare August 4, 2020 22:18

Use click instead of argparse in py instance

122ab3c

Code0x58 force-pushed the click-py-instance branch 2 times, most recently from 0a51882 to d7aea32 Compare August 5, 2020 00:01

Improve heron-python-instance option name consistency

b6aa44d

Code0x58 force-pushed the click-py-instance branch from d7aea32 to b6aa44d Compare August 5, 2020 17:45

Code0x58 marked this pull request as ready for review August 5, 2020 22:59

huijunwu added the PyHeron label Aug 6, 2020

Code0x58 added executor and removed executor labels Aug 10, 2020

Rename instance/st_heron_instance.py to instance.py

ed6aced

This is a clean up which also avoids [this kind of runtime warning](https://stackoverflow.com/questions/43393764/python-3-6-project-structure-leads-to-runtimewarning).

Code0x58 requested a review from huijunwu August 23, 2020 11:32

joshfischer1108 approved these changes Nov 3, 2020

View reviewed changes

Code0x58 merged commit ec44c53 into apache:master Nov 3, 2020

Code0x58 deleted the click-py-instance branch November 3, 2020 15:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use click instead of argparse in py instance #3598

Use click instead of argparse in py instance #3598

Code0x58 commented Aug 4, 2020

huijunwu commented Aug 6, 2020

Code0x58 commented Aug 21, 2020

joshfischer1108 commented Oct 30, 2020

Code0x58 commented Oct 30, 2020

Use click instead of argparse in py instance #3598

Use click instead of argparse in py instance #3598

Conversation

Code0x58 commented Aug 4, 2020

huijunwu commented Aug 6, 2020

Code0x58 commented Aug 21, 2020

joshfischer1108 commented Oct 30, 2020

Code0x58 commented Oct 30, 2020