Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Updating Kryo #3593

Merged
merged 13 commits into from
Aug 24, 2020
Merged

Updating Kryo #3593

merged 13 commits into from
Aug 24, 2020

Conversation

nicknezis
Copy link
Contributor

@nicknezis nicknezis commented Jul 29, 2020

Updating Kryo to a newer version. Currently 5.0.0-RC9 is the most recent release. It includes the necessary updates that I asked for. It should be production ready. RC9 will most likely be the last RC release before the final 5.0.0.

@nicknezis nicknezis self-assigned this Jul 29, 2020
@nicknezis
Copy link
Contributor Author

I'm waiting for some feedback on a feature request in Kryo. Also might wait until the official 5.0.0 release because the remaining issue before release is a performance related issue.

@nicknezis
Copy link
Contributor Author

Waiting on this pull request before this is ready to merge. We will be able to remove the HashSetSerializer once this is incorporated and released as a new Kryo version. EsotericSoftware/kryo#753

@nicknezis nicknezis marked this pull request as ready for review August 14, 2020 17:50
@joshfischer1108
Copy link
Member

joshfischer1108 commented Aug 16, 2020

I built from source and ran an ECO topology locally. No issues I could see. Steps to reproduce are below:


$ bazel build --config=darwin scripts/packages:binpkg

$ ./bazel-bin/scripts/packages/heron-install.sh --user

$ heron version
heron.build.git.revision : bb1509bc56a873ffc91c914a8f5f973ab2981718
heron.build.git.status : Clean
heron.build.host : Joshs-MacBook-Pro-2.local
heron.build.time : Sun Aug 16 16:27:24 CDT 2020
heron.build.timestamp : 1597613244000
heron.build.user : joshfischer
heron.build.version : nicknezis/kryo-upgrade

$ heron submit local ~/.heron/examples/heron-eco-examples.jar org.apache.heron.eco.Eco --eco-config-file ~/.heron/examples/heron_wordcount.yaml 

$ tail -f ~/.herondata/topologies/local/joshfischer/heron-simple-wordcount-topology/log-files/container_1_bolt-2_3.log.0

[2020-08-16 17:50:31 -0500] [INFO] org.apache.heron.examples.eco.LogInfoBolt: { }source: bolt-1, stream: default, [bart, 118]  
[2020-08-16 17:50:31 -0500] [INFO] org.apache.heron.examples.eco.LogInfoBolt: { }source: bolt-1, stream: default, [bart, 119]  
[2020-08-16 17:50:31 -0500] [INFO] org.apache.heron.examples.eco.LogInfoBolt: { }source: bolt-1, stream: default, [bart, 120]  

@joshfischer1108
Copy link
Member

@nwangtw @huijunw could you check this PR before me merge?

@nicknezis nicknezis merged commit f3ba285 into master Aug 24, 2020
@nicknezis nicknezis deleted the nicknezis/kryo-upgrade branch August 24, 2020 19:20
nicknezis added a commit that referenced this pull request Sep 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants