This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if this is the correct fix, but this PR does resolve the issue causing the build to fail. But figured I use these changes to get a conversation started. The reason the
java_doc
command was failing for the storm-compatibility target is because the source files were getting structured in the resulting jar differently than expected. The reason for this is unknown to me still.If you execute on this branch
The output will be a zip file with the javadocs at
If you
cd
into the above directory you will see that some javadoc files are under the folderorg
and others are underjava
if youcd
intojava
you will see other packages such asbacktype
orstorm
which is why the javadoc command could not find the source files. See my abbreviated tree output from the filebazel-bin/storm-compatibility/src/java/heron-storm-javadoc.zip.source
below:So the java_doc rule couldn't find the module
backtype
because it was under thejava
folder in the jar. Either way this PR fixes the problem.