This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
first of the connectors - twitter spout #2852
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlu90
suggested changes
May 8, 2018
| @@ -0,0 +1,126 @@ | |||
| licenses(["notice"]) | |||
There was a problem hiding this comment.
We already have a cereal lib in the third_party dir here.
So please either remove the files here or send out another separate PR for changing this lib
| @@ -0,0 +1,122 @@ | |||
| package com.streamlio.connectors.twitter; | |||
There was a problem hiding this comment.
the package should be org.apache.heron.connectors.twitter now
|
@kramasamy Ping |
|
@kramasamy Let's try to merge this first connector and then keep adding more in the future. Two more suggestions for this PR:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.