This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Add wait for exit function in WakeableLooper and fix exiting code in SocketChannelHelper #2651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng condition in SocketChannelHelper
huijunw
reviewed
Jan 2, 2018
| @@ -213,6 +214,10 @@ public void write() { | |||
| // Force to flush all data in underneath buffer queue to socket with best effort | |||
| // It is most likely happen when we are handling some unexpected cases, such as exiting | |||
| public void forceFlushWithBestEffort() { | |||
| looper.exitLoop(); | |||
| // Wait for NIO loop to confirm stopping process. | |||
| looper.waitForExit(10, TimeUnit.SECONDS); | |||
There was a problem hiding this comment.
what happens if the looper does not stop after 10 seconds
There was a problem hiding this comment.
The function stops waiting and returns false.
In this case, the code works pretty much the same way as before after the waiting. Except exitLoop() set a flag to true so the looper won't do any real work afterwards.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add waitForExit() function in WakeableLooper and use it to avoid racing condition in SocketChannelHelper's forceFlushWithBestEffort() function.
The main motivation of this change is the flaky unit tests in HeronServerTest. However it is possible to happen in real topologies as well in the exiting process.
In the test, a write task is scheduled and executed in a child thread and the main thread calls the flush function. Both threads are consuming the same buffer. When the main thread calls writeToChannel() when buffer size is 0, an assert(and exception) would be triggered.
public class OutgoingPacket {
...
public int writeToChannel(SocketChannel channel) {
int remaining = buffer.remaining();
assert remaining > 0;
....