Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(java): Set parent pom to apache #482

Merged
merged 1 commit into from
May 15, 2024
Merged

feat(java): Set parent pom to apache #482

merged 1 commit into from
May 15, 2024

Conversation

CalvinKirs
Copy link
Member

Reason for this PR

https://maven.apache.org/pom/asf/
Apache Software Foundation Parent POM
contains settings that are likely to be useful to any Apache project that is building and releasing code with Maven. By using this project as a parent, a project gets these settings.
If we have specific version requirements for certain plugins, we need to explicitly declare the corresponding versions in the project. Otherwise, it will default to the version specified in the parent POM.

What changes are included in this PR?

  • Add mailing list and License etc

Comment on lines +61 to +70
<!-- <issueManagement>
<system>GitHub</system>
<url>https://github.com/apache/graphar/issues</url>
</issueManagement>
<scm>
<connection>scm:git:https://github.com/apache/graphar.git</connection>
<developerConnection>scm:git:https://github.com/apache/graphar.git</developerConnection>
<tag>HEAD</tag>
<url>https://github.com/apache/graphar</url>
</scm>-->
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://lists.apache.org/thread/1frk5f146pbzprj0d1ftf15o4z6v3ocs Do we have any plans to drop the "incubator" prefix? There's been an email thread discussing this in the incubator.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://lists.apache.org/thread/1frk5f146pbzprj0d1ftf15o4z6v3ocs Do we have any plans to drop the "incubator" prefix? There's been an email thread discussing this in the incubator.

Thanks for bringing this information to us. Are there specified steps or guidelines that we should follow in response to this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typically, related to infrastructure needs to be handled by the INFRA team. If we're planning to drop the "incubator" prefix, we'll just need to submit a ticket to the INFRA JIRA.
https://issues.apache.org/jira/projects/INFRA/summary

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typically, related to infrastructure needs to be handled by the INFRA team. If we're planning to drop the "incubator" prefix, we'll just need to submit a ticket to the INFRA JIRA. https://issues.apache.org/jira/projects/INFRA/summary

Thanks! I'll consult with other members and make a decision.

Copy link
Contributor

@lixueclaire lixueclaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for making this change!

Copy link
Contributor

@acezen acezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks~

@acezen acezen changed the title [Java]Set parent pom to apache feat(java): Set parent pom to apache May 15, 2024
@acezen acezen merged commit d350bc8 into apache:main May 15, 2024
1 check passed
Elssky pushed a commit to Elssky/incubator-graphar that referenced this pull request Oct 8, 2024
### Reason for this PR

https://maven.apache.org/pom/asf/
Apache Software Foundation Parent POM
contains settings that are likely to be useful to any Apache project that is building and releasing code with Maven. By using this project as a parent, a project gets these settings.
**If we have specific version requirements for certain plugins, we need to explicitly declare the corresponding versions in the project. Otherwise, it will default to the version specified in the parent POM.**
### What changes are included in this PR?
- Add mailing list and License etc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants