-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(java): Put java and spark libraries within a directory maven-projects
to help easily manage and extend the multi-module maven projects
#474
Conversation
Signed-off-by: acezen <[email protected]>
Signed-off-by: acezen <[email protected]>
Signed-off-by: acezen <[email protected]>
This PR will make the |
maven-project
to help easily manage and extend the multi-module maven projectsmaven-projects
to help easily manage and extend the multi-module maven projects
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi, @Thespica @SemyonSinchenko, This change is related to Java and Spark, it's better to get some review or advice for the change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For module in root pom, I consider it should be module name, rather than directory name.
A better solution is unifying the directory name and module names.
Line 33 in b33c1f0
<module>java</module> |
incubator-graphar/spark/pom.xml
Line 34 in b33c1f0
<artifactId>graphar-spark</artifactId> |
incubator-graphar/java/pom.xml
Line 35 in b33c1f0
<artifactId>gar-java</artifactId> |
Make sense to me, I will update it to the directory name. |
Signed-off-by: acezen <[email protected]>
hi, @Thespica, the module name has been unify with directory name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM~
Besides, #467 can be closed, right?
…ojects` to help easily manage and extend the multi-module maven projects (apache#474) --------- Signed-off-by: acezen <[email protected]>
Reason for this PR
Since we would split the java library to multi-module project and spark rely on one of the modules 'info', it's better to put java and spark libraries within a directory. That help easily manage and extend the multi-module maven projects
What changes are included in this PR?
maven-project
Are these changes tested?
yes
Are there any user-facing changes?
No