Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(java): Put java and spark libraries within a directory maven-projects to help easily manage and extend the multi-module maven projects #474

Merged
merged 9 commits into from
May 8, 2024

Conversation

acezen
Copy link
Contributor

@acezen acezen commented May 7, 2024

Reason for this PR

Since we would split the java library to multi-module project and spark rely on one of the modules 'info', it's better to put java and spark libraries within a directory. That help easily manage and extend the multi-module maven projects

What changes are included in this PR?

  • Put java and spark libraries within a directory maven-project
  • Update the related link and document

Are these changes tested?

yes

Are there any user-facing changes?

No

@acezen
Copy link
Contributor Author

acezen commented May 7, 2024

This PR will make the branch-feat-spark-java-info-refactoring branch easily to merge into the main.

@acezen acezen changed the title feat(java): Put java and spark libraries within a directory maven-project to help easily manage and extend the multi-module maven projects feat(java): Put java and spark libraries within a directory maven-projects to help easily manage and extend the multi-module maven projects May 7, 2024
Copy link
Contributor

@lixueclaire lixueclaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acezen
Copy link
Contributor Author

acezen commented May 7, 2024

Hi, @Thespica @SemyonSinchenko, This change is related to Java and Spark, it's better to get some review or advice for the change.

Copy link
Member

@SemyonSinchenko SemyonSinchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Thespica Thespica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For module in root pom, I consider it should be module name, rather than directory name.

A better solution is unifying the directory name and module names.

<module>java</module>

<artifactId>graphar-spark</artifactId>

<artifactId>gar-java</artifactId>

@acezen
Copy link
Contributor Author

acezen commented May 7, 2024

For module in root pom, I consider it should be module name, rather than directory name.

A better solution is unifying the directory name and module names.

<module>java</module>

<artifactId>graphar-spark</artifactId>

<artifactId>gar-java</artifactId>

Make sense to me, I will update it to the directory name.

@acezen
Copy link
Contributor Author

acezen commented May 8, 2024

hi, @Thespica, the module name has been unify with directory name.

Copy link
Contributor

@Thespica Thespica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~
Besides, #467 can be closed, right?

@acezen
Copy link
Contributor Author

acezen commented May 8, 2024

LGTM~ Besides, #467 can be closed, right?

yes, #467 is solved by this PR.

@acezen acezen merged commit 71f57b3 into apache:main May 8, 2024
6 checks passed
Elssky pushed a commit to Elssky/incubator-graphar that referenced this pull request Oct 8, 2024
…ojects` to help easily manage and extend the multi-module maven projects (apache#474)



---------

Signed-off-by: acezen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants