Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra] Remove the third party action from CI #439

Merged
merged 6 commits into from
Apr 5, 2024

Conversation

acezen
Copy link
Contributor

@acezen acezen commented Apr 5, 2024

Proposed changes

Apache project only allows to use github or apache's actions, try to replace the third-party action in CI.

@SemyonSinchenko
Copy link
Member

@acezen, do you need help here with all this python stuff?

@acezen
Copy link
Contributor Author

acezen commented Apr 5, 2024

@acezen, do you need help here with all this python stuff?

yeah, Apache only allows project to use github/apache's actions in CI, can you help me how to replace the poetry related action in CI?

@SemyonSinchenko
Copy link
Member

Of course. I will do it in the evening.

@acezen
Copy link
Contributor Author

acezen commented Apr 5, 2024

Of course. I will do it in the evening.

that's great! thanks Sem.

@SemyonSinchenko
Copy link
Member

@acezen This way is working for me:

    - name: Install Poetry
      run: |
          yes | sudo python3 -m pip install poetry --quiet
          cd pyspark
          poetry env use python3

I tried it in my fork and it works

I see that you already made a lot of changes, so we can merge your current work and I will fix broken pipelines, or you can just copy-paste the way how I install poetry and it should work.

@acezen
Copy link
Contributor Author

acezen commented Apr 5, 2024

@acezen This way is working for me:

    - name: Install Poetry
      run: |
          yes | sudo python3 -m pip install poetry --quiet
          cd pyspark
          poetry env use python3

I tried it in my fork and it works

I see that you already made a lot of changes, so we can merge your current work and I will fix broken pipelines, or you can just copy-paste the way how I install poetry and it should work.

Thanks Sem, I will try to copy-paste to check the CI.

@acezen acezen requested a review from SemyonSinchenko April 5, 2024 13:08
@acezen
Copy link
Contributor Author

acezen commented Apr 5, 2024

Hi, @SemyonSinchenko, it works! Can you take a review for the changes?

Signed-off-by: acezen <[email protected]>
@SemyonSinchenko
Copy link
Member

I think we still need to switch to latest Ubuntu, because 20.04 will stop getting security updates in the middle of 2024. I would suggest latest or 22.04.

Signed-off-by: acezen <[email protected]>
Copy link
Member

@SemyonSinchenko SemyonSinchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acezen
Copy link
Contributor Author

acezen commented Apr 5, 2024

for

It seems that the CI still run a ubuntu-20.04, we can merge this change first, and change to ubuntu-latest in another PR.

@acezen acezen merged commit 10f7569 into apache:main Apr 5, 2024
2 checks passed
@acezen acezen deleted the remove-third-party-action branch April 5, 2024 13:44
Elssky pushed a commit to Elssky/incubator-graphar that referenced this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants