Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix][C++] Check is not nullptr before calling ToString and fix empty prefix bug #339

Merged
merged 5 commits into from
Jan 24, 2024

Conversation

acezen
Copy link
Contributor

@acezen acezen commented Jan 24, 2024

Proposed changes

see issue #338 #340
and one more:
GraphInfo is invalid when prefix is empty, since the prefix of graph info is the begin prefix of all paths, it should be empty and no default value.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

close #338
close #340

@acezen acezen requested a review from lixueclaire January 24, 2024 02:08
@acezen acezen changed the title [BugFix][C++] Check is not nullptr before calling ToString [BugFix][C++] Check is not nullptr before calling ToString and fix empty prefix bug Jan 24, 2024
@acezen
Copy link
Contributor Author

acezen commented Jan 24, 2024

@lixueclaire , this Pull Request needs your review~

@acezen acezen merged commit 48fb25e into apache:main Jan 24, 2024
4 checks passed
@acezen acezen deleted the 338-fix-edge-info-dump branch January 24, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants