-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat][C++] Support List Data Type, use list<float>
as example
#296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acezen
commented
Dec 19, 2023
acezen
changed the title
[C++][Improvement] Support List Data Type, use
[Feat][C++] Support List Data Type, use Dec 20, 2023
list<float>
as examplelist<float>
as example
hi,@lixueclaire , Do you want to give this a review? |
OK, I'll have a look right now. |
lixueclaire
reviewed
Dec 21, 2023
lixueclaire
reviewed
Dec 21, 2023
lixueclaire
reviewed
Dec 21, 2023
lixueclaire
reviewed
Dec 21, 2023
Signed-off-by: acezen <[email protected]>
lixueclaire
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This pull request aims to support
List
data type in GraphAr C++ and add related unit-testList
data type by add achild_
toDataType
class, implement by nested other logical data type.Vertex
/Edge
.yaml example:
NB: since BooleanArray and StringArray'method are not align to NumericalArray, so we only support
list<int32>
list<int64>
,list<float>
andlist<double>
at present.Types of changes
What types of changes does your code introduce to GraphAr?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
close issue #287
related to #169