Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat][C++] Support List Data Type, use list<float> as example #296

Merged
merged 10 commits into from
Dec 21, 2023

Conversation

acezen
Copy link
Contributor

@acezen acezen commented Dec 19, 2023

Proposed changes

This pull request aims to support List data type in GraphAr C++ and add related unit-test

  • Support List data type by add a child_ to DataType class, implement by nested other logical data type.
  • In high level reader, support read list property in Vertex/Edge.
    yaml example:
property:
  - name: feature
  - data_type: list<float>
  - is_primary: false

NB: since BooleanArray and StringArray'method are not align to NumericalArray, so we only support list<int32> list<int64>, list<float> and list<double> at present.

Types of changes

What types of changes does your code introduce to GraphAr?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

close issue #287
related to #169

@acezen acezen marked this pull request as ready for review December 19, 2023 09:20
@acezen acezen requested a review from lixueclaire December 19, 2023 09:20
cpp/include/gar/graph.h Outdated Show resolved Hide resolved
@acezen acezen changed the title [C++][Improvement] Support List Data Type, use list<float> as example [Feat][C++] Support List Data Type, use list<float> as example Dec 20, 2023
@acezen
Copy link
Contributor Author

acezen commented Dec 21, 2023

hi,@lixueclaire , Do you want to give this a review?

@lixueclaire
Copy link
Contributor

hi,@lixueclaire , Do you want to give this a review?

OK, I'll have a look right now.

cpp/test/test_graph.cc Outdated Show resolved Hide resolved
@acezen acezen merged commit 3fa4a78 into apache:main Dec 21, 2023
5 checks passed
@acezen acezen deleted the 287-support-list-float-type branch December 21, 2023 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants